feat: Limit number of fields targeted by a regex#67
Closed
Darkheir wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds a guardrail in the doc-mapper query builder to limit how many distinct fields a single query can target with regex clauses, preventing overly expensive regex-heavy queries from impacting system performance.
Changes:
- Introduces a
MAX_REGEX_QUERY_FIELDScap and collects targeted regex fields via aQueryAstVisitor. - Enforces the cap early in
build_query, returning an error when exceeded. - Adds unit tests covering rejection/acceptance boundaries for the new limit.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Darkheir <raphael.cohen@sekoia.io>
Darkheir
force-pushed
the
feat/regex_field_limit
branch
from
cf68057 to
94527ad
Compare
Collaborator
Author
|
Closing it in favor of #68 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe the proposed changes made in this PR.
How was this PR tested?
Describe how you tested this PR.