Fix regex combination issue#69
Open
rdettai-sk wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the ES compatibility REST API scenario for regex/wildcard matching, aiming to reproduce (and guard against) failures when building a combined automaton from multiple patterns across several fields.
Changes:
- Comments out the existing
regexp-focused scenario steps in0031-regex.yaml. - Adds a new active scenario step containing a deeply nested
boolquery with manywildcardclauses (case-insensitive) across multiple fields, expecting0hits (and implicitly requiring the query to be accepted without error).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
158d299 to
ae0935e
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
quickwit/rest-api-tests/scenarii/es_compatibility/0031-regex.yaml:16
- This scenario file previously contained multiple regex-related test cases, but they are now entirely commented out. That effectively drops coverage for the original regexp behaviors (basic match, anchoring behavior, case_insensitive, anchors escaping, query_string regex) and makes the file only exercise the new wildcard-heavy query.
Instead of commenting out the earlier scenarios, they should stay active and the new reproduction should be added as an additional YAML document (separated by ---).
# Basic regex match
params:
size: 0
json:
track_total_hits: true
query:
regexp:
type:
value: ".*event"
expected:
hits:
total:
value: 100
relation: "eq"
---
# Regex always match from start to end (`(re)` equivalent to `^(re)$`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Got
How was this PR tested?
Describe how you tested this PR.