Skip to content

Fix regex combination issue#69

Open
rdettai-sk wants to merge 2 commits into
sekoiafrom
fix-regex-combination-issue
Open

Fix regex combination issue#69
rdettai-sk wants to merge 2 commits into
sekoiafrom
fix-regex-combination-issue

Conversation

@rdettai-sk

Copy link
Copy Markdown
Collaborator

Description

Got

regex_res: Err(
    Error {
        context: "failed to build combined regex automaton during warmup for field `_dynamic` (path: `process\u{1}executable\0s`, 6 patterns)",
        source: TooManyStates(
            1000,
        ),
    },

How was this PR tested?

Describe how you tested this PR.

Copilot AI review requested due to automatic review settings June 22, 2026 15:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the ES compatibility REST API scenario for regex/wildcard matching, aiming to reproduce (and guard against) failures when building a combined automaton from multiple patterns across several fields.

Changes:

  • Comments out the existing regexp-focused scenario steps in 0031-regex.yaml.
  • Adds a new active scenario step containing a deeply nested bool query with many wildcard clauses (case-insensitive) across multiple fields, expecting 0 hits (and implicitly requiring the query to be accepted without error).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread quickwit/rest-api-tests/scenarii/es_compatibility/0031-regex.yaml Outdated
Comment thread quickwit/rest-api-tests/scenarii/es_compatibility/0031-regex.yaml
Comment thread quickwit/rest-api-tests/scenarii/es_compatibility/0031-regex.yaml Outdated
@rdettai-sk rdettai-sk force-pushed the fix-regex-combination-issue branch from 158d299 to ae0935e Compare June 23, 2026 13:25

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

quickwit/rest-api-tests/scenarii/es_compatibility/0031-regex.yaml:16

  • This scenario file previously contained multiple regex-related test cases, but they are now entirely commented out. That effectively drops coverage for the original regexp behaviors (basic match, anchoring behavior, case_insensitive, anchors escaping, query_string regex) and makes the file only exercise the new wildcard-heavy query.

Instead of commenting out the earlier scenarios, they should stay active and the new reproduction should be added as an additional YAML document (separated by ---).

# Basic regex match
params:
  size: 0
json:
  track_total_hits: true
  query:
    regexp:
      type:
        value: ".*event"
expected:
  hits:
    total:
      value: 100
      relation: "eq"
---
# Regex always match from start to end (`(re)` equivalent to `^(re)$`)

Comment thread quickwit/quickwit-search/src/leaf.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants