Add sendspin-jvm client implementation#54
Merged
Conversation
- Add src/conformance/adapters/sendspin_jvm_client.py — Python wrapper that locates and invokes the conformance-client fat JAR from the sendspin-jvm repo - Register sendspin-jvm in IMPLEMENTATIONS: same capabilities as the android-tv JVM client (FLAC, no Opus, no discovery, all role families, both connection modes) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
balloob
reviewed
May 11, 2026
Comment on lines
+3
to
+7
| Drop this file into the conformance harness at: | ||
| src/conformance/adapters/sendspin_jvm_client.py | ||
|
|
||
| Then add an entry to src/conformance/implementations.py — see the project README | ||
| or the CI workflow for the exact entry. |
balloob
reviewed
May 11, 2026
| / "conformance-client" | ||
| / "build" | ||
| / "libs" | ||
| / "conformance-client.jar" |
Collaborator
There was a problem hiding this comment.
I think this is the wrong approach. With the other SDKs, the conformance adapter lives in this repository and we do the build.
balloob
requested changes
May 11, 2026
Collaborator
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
The conformance adapter should live in this repository.
…o_path
- toolchains.py: add find_java() following the pattern of other toolchain helpers
- build.py: add _gradle_build_result() that checks out sendspin-jvm, runs
./gradlew :conformance-client:jar, and sets runtime_command_prefix to
["java", "-jar", <jar>]; register it as "sendspin-jvm-client" in _build_plan
- sendspin_jvm_client.py: fix docstring; resolve JAR via
resolve_required_repo_path("sendspin-jvm") instead of parents[4] navigation;
use find_java() from toolchains
- implementations.py: change build_adapter from "python-adapters" to
"sendspin-jvm-client"
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
balloob
reviewed
May 11, 2026
|
|
||
| gradlew = repo / ("gradlew.bat" if os.name == "nt" else "gradlew") | ||
| jar = repo / "conformance-client" / "build" / "libs" / "conformance-client.jar" | ||
| completed = _run_command([str(gradlew), ":conformance-client:jar"], cwd=repo) |
Collaborator
There was a problem hiding this comment.
The actual source code for conformance-client should be in this repo
- Add adapters/sendspin-jvm/client/ with Kotlin source (Main.kt, CollectingAudioPlayer.kt, NoOpNsdBrowser.kt, NoOpNsdRegistrar.kt) and Gradle build files; settings.gradle.kts includes :sendspin-protocol from repos/sendspin-jvm via the same relative-path pattern used by sendspin-rs and sendspin-dotnet - build.py: update _gradle_build_result() to build from the adapter dir using sendspin-jvm's gradlew with --project-dir; JAR output lands in adapters/sendspin-jvm/client/build/libs/ - sendspin_jvm_client.py: simplify JAR path to repo_root() / adapters/..., no longer needs resolve_required_repo_path - implementations.py: remove sendspin-android-tv (private repo; cloning it broke setup_repositories.py in CI); sendspin-jvm supersedes it Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 tasks
balloob
approved these changes
May 11, 2026
Contributor
Author
|
Looks like this needs a follow up: #55 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/conformance/adapters/sendspin_jvm_client.py— Python wrapper that locates and invokes the conformance-client fat JAR fromsendspin-jvmsendspin-jvminIMPLEMENTATIONS: FLAC, no Opus, no discovery, all four role families, both connection modesTest plan
conformance run --from aiosendspin --to sendspin-jvmpasses after the JAR is built from a tagged release