Develop#616
Merged
Merged
Conversation
…to fix banners not loading from cache in chromium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and minor fixes to the video details update flow, image loading reliability, and general code robustness across the client application. The changes enhance the user experience when editing video details, improve UI consistency, and add defensive programming practices.
Video details update and callback handling:
handleVideoUpdatefunction inGameVideos.jsto update video details in state after edits, and passed it asupdateCallbacktoVideoModal, ensuring UI stays in sync after updates. [1] [2]VideoModal.jsto callupdateCallbackdefensively (using optional chaining) after video details or privacy changes, preventing errors if the callback is not provided. [1] [2]UpdateDetailsModal.jsto use the nullish coalescing operator (??) fordescription, ensuring empty string values are handled correctly and not overwritten by fallback values. [1] [2]Image loading reliability:
GameVideosHeader.jsby using arefto check if the image is already loaded (important for cached images in Chromium), ensuring the UI accurately reflects the image load state. [1] [2]UI and code style improvements:
font-familyproperty inindex.cssfor better readability and maintainability.Package version update:
1.6.7to1.6.8in bothpackage.jsonandpackage-lock.json. [1] [2]