Develop#621
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a database migration and supporting code changes to ensure that each video can only be linked to a particular game once, removing any existing duplicate links. It also updates the video player's UI by customizing the overlay gradient and cleans up related CSS. The version is bumped to 1.6.9 to reflect these updates.
Database integrity improvements:
video_game_linktable on the combination ofvideo_idandgame_id, ensuring no duplicate links between a video and a game. Existing duplicates are removed in the migration (migrations/versions/n9i0j1k2l3m4_unique_video_game_link.py,app/server/fireshare/models.py). [1] [2]VideoGameLink, preventing duplicate entries at the application level (app/server/fireshare/cli.py).Video player UI enhancements:
videoSkinOverrides.css, to constrain the video player's controls overlay gradient to the bottom 25% of the video, improving visual clarity (app/client/src/components/player/videoSkinOverrides.css,app/client/src/components/player/VideoJSPlayer.js). [1] [2]app/client/src/index.css).Version update:
package.jsonandpackage-lock.jsonto reflect these changes (app/client/package.json,app/client/package-lock.json). [1] [2]