Add template code for multi-class discounts in rust by lindadamus · Pull Request #588 · Shopify/function-examples

lindadamus · 2025-01-17T18:13:22Z

This creates three discounts:

X% discount on most expensive cart line
Y% discount on all order subtotal
Z% discount on all delivery groups

jonathanhamel4 · 2025-01-23T18:40:11Z

discounts/rust/discounts/default/Cargo.toml.liquid

+name = "{{handle | replace: " ", "-" | downcase}}"
+version = "1.0.0"
+edition = "2021"
+rust-version = "1.62"


This version is old. We currentl use 1.83, should we update it? 1.62 is the one used in the other targets (older templates in this repo)

I don't know for sure, but it seems sensible to start out with the latest Rust version that we're supporting in the CLI, rather than something older.

jonathanhamel4 · 2025-01-24T14:13:52Z

discounts/rust/discounts/default/src/run.rs

+    query_path = "src/run.graphql",
+    schema_path = "schema.graphql"
+)]
+fn cart_run(input: CartResponseData) -> Result<FunctionCartRunResult> {


This cart_run will make:

return no discount if the previous response was not a 200. (Could check specifically for 401, or the body)

a X% order percent discount on subTotal target

a Y% product discount on the highest cartLine cost (any better idea?)

jonathanhamel4 · 2025-01-24T14:16:42Z

discounts/rust/discounts/default/src/run.rs

+    query_path = "src/run.graphql",
+    schema_path = "schema.graphql"
+)]
+fn delivery_run(input: DeliveryResponseData) -> Result<FunctionDeliveryRunResult> {


This delivery_run will make:

no discount if fetch did not return a 200. As above, I could check if 401 or the body.

a Z% discount on all delivery groups

jonathanhamel4 · 2025-01-24T14:17:27Z

discounts/rust/discounts/default/src/run.rs

+    query_path = "src/fetch.graphql",
+    schema_path = "schema.graphql"
+)]
+fn cart_fetch(input: CartFetchResponseData) -> Result<FunctionCartFetchResult> {


Fetch will return an HttpRequest passing down the email of the buyer. Another idea?

We could have Fetch validate the enteredDiscountCodes and return them in the Fetch result. Then the Run result can include the addValidDiscountCodes operation with the codes that Fetch said were valid.

Also, should the code for Fetch be in a different fetch.rs file? I see that's what other Function templates have done (example).

We could have Fetch validate the enteredDiscountCodes and return them in the Fetch result. Then the Run result can include the addValidDiscountCodes operation with the codes that Fetch said were valid.

Good idea. I will make that change.

Also, should the code for Fetch be in a different fetch.rs file? I see that's what other Function templates have done (example).

I have to say, I'm not sure about this. Can probably have different files. I'll have a look .

jonathanhamel4 · 2025-01-24T14:17:36Z

discounts/rust/discounts/default/src/run.rs

+    query_path = "src/fetch.graphql",
+    schema_path = "schema.graphql"
+)]
+fn delivery_fetch(input: DeliveryFetchResponseData) -> Result<FunctionDeliveryFetchResult> {


Fetch will return an HttpRequest passing down the email of the buyer. Another idea?

lindadamus

I can't approve because I created this PR 😢 (which is deceptive because you've done all the work here!), but just to say that none of my comments are blocking and any that we want to address can be done iteratively in follow-up PRs.

lindadamus · 2025-01-24T15:45:01Z

discounts/rust/discounts/default/Cargo.toml.liquid

+[package]
+name = "{{handle | replace: " ", "-" | downcase}}"
+version = "1.0.0"
+edition = "2021"


Should this be "2025"?

lindadamus · 2025-01-24T15:46:13Z

discounts/rust/discounts/default/Cargo.toml.liquid

+name = "{{handle | replace: " ", "-" | downcase}}"
+version = "1.0.0"
+edition = "2021"
+rust-version = "1.62"


I don't know for sure, but it seems sensible to start out with the latest Rust version that we're supporting in the CLI, rather than something older.

lindadamus · 2025-01-24T15:48:55Z

discounts/rust/discounts/default/README.md

+You can build this individual function using `cargo build`.
+
+```shell
+cargo build --target=wasm32-wasip1 --release


Wasn't this target added with the newer Rust version? Seems this could also be a reason to bump the Rust version.

That is true, however this target has been available before this release, it just became the new default with 1.84

lindadamus · 2025-01-24T15:53:20Z

discounts/rust/discounts/default/src/fetch.graphql.liquid

+      buyerIdentity {
+        email
+      }
+  }


We should include enteredDiscountCodes in the fetch input query.

lindadamus · 2025-01-24T16:05:51Z

discounts/rust/discounts/default/src/run.rs

+    query_path = "src/fetch.graphql",
+    schema_path = "schema.graphql"
+)]
+fn cart_fetch(input: CartFetchResponseData) -> Result<FunctionCartFetchResult> {


We could have Fetch validate the enteredDiscountCodes and return them in the Fetch result. Then the Run result can include the addValidDiscountCodes operation with the codes that Fetch said were valid.

Also, should the code for Fetch be in a different fetch.rs file? I see that's what other Function templates have done (example).

lindadamus · 2025-01-24T16:10:00Z

discounts/rust/discounts/default/src/run.rs

+                id: cart_line_id.to_string(),
+                quantity: Some(1),
+            })],
+            associated_discount_code: None,


If we add enteredDiscountCode validation in the Fetch function, then we could include an associated_discount_code from the valid discount codes returned by the Fetch.

devisscher

Let's merge this and improve iteratively as suggested by Linda. 🙌

jonathanhamel4 · 2025-01-27T21:35:21Z

@lindadamus I've updated the code. Lmk if that works with you. In the meantime, I'll merge it and please comment here and I will fast follow on it.

lindadamus · 2025-01-27T21:50:10Z

Looks good! I haven't done a tophat but should be able to tomorrow when all the pieces are in place (CLI, partners, templas).

Add template code for multi-class discounts

c3da6f0

lindadamus force-pushed the lindadamus/add_multiclass_discounts branch from cb28b1c to c3da6f0 Compare January 17, 2025 18:18

implement all targets and read from the fetch function

1e55047

jonathanhamel4 reviewed Jan 23, 2025

View reviewed changes

jonathanhamel4 force-pushed the lindadamus/add_multiclass_discounts branch 2 times, most recently from b8857ca to f8645e9 Compare January 23, 2025 20:54

remove other targets for now

199c691

jonathanhamel4 force-pushed the lindadamus/add_multiclass_discounts branch 2 times, most recently from 3e2f2b6 to 49535f4 Compare January 24, 2025 14:12

jonathanhamel4 reviewed Jan 24, 2025

View reviewed changes

jonathanhamel4 force-pushed the lindadamus/add_multiclass_discounts branch from 49535f4 to 43d48f8 Compare January 24, 2025 15:20

jonathanhamel4 changed the title ~~Add template code for multi-class discounts~~ Add template code for multi-class discounts in rust Jan 24, 2025

discount using metafield and rest from actual cart

d246160

jonathanhamel4 force-pushed the lindadamus/add_multiclass_discounts branch from 43d48f8 to d246160 Compare January 24, 2025 15:23

jonathanhamel4 requested review from a team, devisscher, lgriffee and nicolasmartino-dev and removed request for a team January 24, 2025 15:23

jonathanhamel4 marked this pull request as ready for review January 24, 2025 15:24

jonathanhamel4 requested review from a team and samihibrahim and removed request for a team and lgriffee January 24, 2025 15:25

lindadamus commented Jan 24, 2025

View reviewed changes

AronZeng approved these changes Jan 27, 2025

View reviewed changes

devisscher approved these changes Jan 27, 2025

View reviewed changes

use enteredDiscountCode

a258837

jonathanhamel4 force-pushed the lindadamus/add_multiclass_discounts branch from 45323b5 to a258837 Compare January 27, 2025 21:37

jonathanhamel4 merged commit 77efe7a into main Jan 27, 2025
4 checks passed

jonathanhamel4 deleted the lindadamus/add_multiclass_discounts branch January 27, 2025 21:44

Conversation

lindadamus commented Jan 17, 2025 • edited by jonathanhamel4 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonathanhamel4 Jan 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lindadamus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jonathanhamel4 Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

devisscher left a comment

Choose a reason for hiding this comment

Uh oh!

jonathanhamel4 commented Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

lindadamus commented Jan 27, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lindadamus commented Jan 17, 2025 •

edited by jonathanhamel4

Loading

jonathanhamel4 Jan 24, 2025 •

edited

Loading

jonathanhamel4 Jan 27, 2025 •

edited

Loading

jonathanhamel4 commented Jan 27, 2025 •

edited

Loading