Handle generated columns on ghostferry write operations.#400
Open
proton-lisandro-pin wants to merge 1 commit intoShopify:mainfrom
Open
Handle generated columns on ghostferry write operations.#400proton-lisandro-pin wants to merge 1 commit intoShopify:mainfrom
proton-lisandro-pin wants to merge 1 commit intoShopify:mainfrom
Conversation
Author
|
Friendly ping? |
Contributor
|
Thoughts about excluding virtual columns from the MD5 compute? |
Author
Ah, good call - we should definitely not be hashing those methinks. Fixed. |
proton-lisandro-pin
force-pushed
the
generated_columns_fix
branch
2 times, most recently
from
07bc0ff to
74ca32a
Compare
This PR modifies all `INSERT` logic so virtual (a.k.a generated) MySQL columns are not attempted to insert into, which otherwise breaks the ferrying process. See also Shopify#338.
proton-lisandro-pin
force-pushed
the
generated_columns_fix
branch
from
74ca32a to
26fcafe
Compare
Author
|
(second) Friendly ping? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR modifies all
INSERTlogic so virtual (a.k.a generated) MySQL columns are not written into, which would otherwise break the ferrying process.See also #338.