add timeout to super().request(). Ducobox may sometimes hang.#18
Open
wouterteepe wants to merge 1 commit intoSikerdebaard:mainfrom
Open
add timeout to super().request(). Ducobox may sometimes hang.#18wouterteepe wants to merge 1 commit intoSikerdebaard:mainfrom
wouterteepe wants to merge 1 commit intoSikerdebaard:mainfrom
Conversation
…quest #19 of hacs-ducobox-connector in an elegant way, at the source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DucoUrlSessionextendsrequests.Sessionbut doesn't set timeouts on HTTP calls. When super().request() is called without a timeout parameter, requests can hang indefinitely.This is observed in pull request Sikerdebaard/hacs-ducobox-connector#39.
Instead of adding lots of code to that library, let's address it at the source.
The timeout is set at 15 seconds. No strong opinions on what the timeout should be, except that it should ideally be below one minute and allow some lag of the ducobox.
Please note that this issue can also occur without even using hacs-ducobox-connector, but just by using docupy itself. Or, more honestly, it occurs with the ducobox itself, which is sometimes not responsive. (I'll configure it to reboot frequently, but still the library should handle timeouts graceously).