Skip to content

Add --runtime support with completing-read #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Silex merged 2 commits into from
Jun 23, 2026
Merged

Add --runtime support with completing-read #256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
475b94f
Add --runtime support with completing-read
djr7C4 Jun 21, 2026
fa8ca4b
Merge branch 'main' into runtimes
djr7C4 Jun 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 34 additions & 1 deletion docker-image.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,38 @@ applied to the buffer."
(tablist-put-mark))
(forward-line))))

(aio-defun docker-image-default-runtime ()
(s-trim (aio-await (docker-run-docker-async "info" "-f" "{{.DefaultRuntime}}"))))

(aio-defun docker-image-runtimes ()
(let ((default (aio-await (docker-image-default-runtime))))
(--> (docker-run-docker-async "info" "-f" "'{{range $name, $_ := .Runtimes}}{{println $name}}{{end}}'")
aio-await
(s-split "\n" it t)
;; Remove alias for runc.
(-remove (-partial #'s-starts-with-p "io.containerd") it)
;; Ensure that default is first.
(remove default it)
(cons default it))))

(defun docker-image-read-runtime (prompt &rest _)
(completing-read prompt
(let ((runtimes (aio-wait-for (docker-image-runtimes))))
;; Complete with the runtimes in the order given by
;; `docker-image-runtimes' don't re-sort them. Some
;; completion frameworks don't change the order but some
;; (e.g. vertico) do by default. See
;; [[info:elisp#Programmed Completion][Programmed
;; Completion]].
(lambda (string predicate action)
(if (eq action 'metadata)
'(metadata
(display-sort-function . identity)
(cycle-sort-function . identity))
(complete-with-action action runtimes string predicate))))
nil
t))

(docker-utils-define-transient-arguments docker-image-ls)

(transient-define-prefix docker-image-ls ()
Expand Down Expand Up @@ -378,7 +410,8 @@ applied to the buffer."
("t" "TTY" "-t")
("u" "User" "-u " read-string)
("v" "Volume" "-v " read-string)
("w" "Workdir" "-w " read-string)]
("w" "Workdir" "-w " read-string)
("x" "Runtime" "--runtime " docker-image-read-runtime)]
[:description docker-generic-action-description
("R" "Run" docker-image-run-selection)])

Expand Down