feat(core): Implement more events#74
Draft
kxmpxtxnt wants to merge 27 commits into
Draft
Conversation
Member
Author
|
I've also a more general question. @jakobkmar how was it intended to mutate values of the paper event. It seems that they currently only call the silk events without any result manipulation |
kxmpxtxnt
changed the title
kxmpxtxnt
changed the title
…nt instead of PlayerDeathEvent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think it would be an great idea to implement all the events in one pr and merge it regularly.
Feel free to ask for specific events you're missing (currently basically all are missing xd).