feat: Add edit message support. (closes #336) by vasu-nageshri · Pull Request #438 · SimformSolutionsPvtLtd/chatview

vasu-nageshri · 2026-05-12T05:49:30Z

Description

Add enableEditMessage flag to FeatureActiveConfig (default: true)
Add onEditTap callback to ChatView and ReplyPopupConfiguration
Add EditMessageCallback typedef
Create EditMessageView widget showing 'Editing' indicator above textfield
Extend SendMessageWidget with assignEditMessage() and edit mode logic
Add Edit button to ReplyPopupWidget (own messages only)
Wire assignEditMessage through ChatListWidget -> ChatView
Show 'Edited' label on messages where updateAt is non-null
Add edit/edited/editing strings to ChatViewLocale (backward-compatible)
Expose ChatView.getEditingMessage() static helper
Add doc/documentation.md section for Edit Message feature

Visual Representation

Screen_recording_20260512_135107.mp4

Checklist

The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
I have followed the Contributor Guide when preparing my PR.
I have updated/added tests for ALL new/updated/fixed functionality.
I have updated/added relevant documentation in docs and added dartdoc comments with ///.
I have updated/added relevant examples in examples or docs.

Breaking Change?

Yes, this PR is a breaking change.
No, this PR is not a breaking change.

Related Issues

Closes #336

Copilot

Pull request overview

Adds first-class “edit message” support to ChatView, wiring an edit action from the long-press popup into the input area, and exposing callbacks/localization needed for consumers to update their message source-of-truth.

Changes:

Introduces edit-mode state in the input (SendMessageWidget) with a new EditMessageView indicator and EditMessageCallback.
Adds an “Edit” option to the reply popup (own messages only) and threads assignEditMessage through ChatListWidget -> ChatView.
Adds locale strings (edit/edited/editing), an “Edited” label for updated messages, and documentation/changelog updates.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
lib/src/widgets/send_message_widget.dart	Adds edit-mode state, assigns an editing message, and routes Send to `onEditTap` when editing.
lib/src/widgets/reply_popup_widget.dart	Adds an optional “Edit” button to the long-press popup (own messages only).
lib/src/widgets/edit_message_view.dart	New widget to display an editing indicator above the input area.
lib/src/widgets/chat_view.dart	Exposes `onEditTap`, wires `assignEditMessage`, and adds `getEditingMessage()` helper.
lib/src/widgets/chat_list_widget.dart	Wires the popup Edit action to enter edit mode and call configuration callback.
lib/src/widgets/chat_bubble_widget.dart	Displays an “Edited” label when `updateAt` is non-null.
lib/src/values/typedefs.dart	Adds `EditMessageCallback` typedef.
lib/src/utils/chat_view_locale.dart	Adds `edit/edited/editing` strings (backward-compatible defaults).
lib/src/models/config_models/reply_popup_configuration.dart	Adds `onEditTap` to reply popup configuration.
lib/src/models/config_models/feature_active_config.dart	Adds `enableEditMessage` flag (default true).
lib/chatview.dart	Exports `EditMessageView`.
doc/documentation.md	Documents the new Edit Message feature and integration steps.
CHANGELOG.md	Adds unreleased changelog entry for edit-message support.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

    _textEditingController.clear();
    if (messageText.isEmpty) return;

+    // If in edit mode, delegate to onEditTap instead of onSendTap.
+    if (isEditMode) {
+      widget.onEditTap?.call(_editingMessage!, messageText);
+      _closeEditMode();
+      return;
+    }
+


+    if (_editMessageViewKey.currentState == null) {
+      setState(() {});
+    } else {
+      _editMessageViewKey.currentState!.editMessage.value = message;
+    }
+  }


vatsaltanna-simformsolutions · 2026-05-12T09:04:44Z

+                onEditTap: sentByCurrentUser &&
+                        (featureActiveConfig?.enableEditMessage ?? true)
+                    ? () {
+                        widget.assignEditMessage?.call(message);
+                        if (featureActiveConfig?.enableReactionPopup ?? false) {
+                          chatViewIW?.showPopUp.value = false;
+                        }
+                        ScaffoldMessenger.of(context).hideCurrentSnackBar();
+                        replyPopup?.onEditTap?.call(message);
+                      }


take this as separate function for code readability

+/// Displays an "Editing" header with the original message preview and a
+/// close button to cancel the edit.


japanshah-simform · 2026-05-15T08:17:20Z

+/// [newText] is the updated text content.
+typedef EditMessageCallback = void Function(
+  Message message,
+  String newText,


change the parameter name to updatedMessage or editedMessage.

japanshah-simform · 2026-05-15T08:50:40Z

  ReplyMessage _replyMessage = const ReplyMessage();

+  /// The message currently being edited, or `null` if not in edit mode.
+  Message? _editingMessage;


please check for naming convention, editingMessage seems to be a method name.

japanshah-simform · 2026-05-15T08:55:19Z

+  /// message text in-place.
+  ///
+  /// Defaults to `true`.
+  final bool enableEditMessage;


can we rename to enableMessageEditing?

readme needs to be update with this changes too

- Add enableEditMessage flag to FeatureActiveConfig (default: true) - Add onEditTap callback to ChatView and ReplyPopupConfiguration - Add EditMessageCallback typedef - Create EditMessageView widget showing 'Editing' indicator above textfield - Extend SendMessageWidget with assignEditMessage() and edit mode logic - Add Edit button to ReplyPopupWidget (own messages only) - Wire assignEditMessage through ChatListWidget -> ChatView - Show 'Edited' label on messages where updateAt is non-null - Add edit/edited/editing strings to ChatViewLocale (backward-compatible) - Expose ChatView.getEditingMessage() static helper - Add doc/documentation.md section for Edit Message feature

japanshah-simform

Approved.

vatsaltanna-simformsolutions · 2026-05-15T09:52:13Z

+      message: newText,
+      createdAt: originalMessage.createdAt,
+      sentBy: originalMessage.sentBy,
+      updateAt: DateTime.now(), // marks the message as edited


vatsaltanna-simformsolutions · 2026-05-15T09:52:55Z

+    // Set `updateAt` on the message to trigger the "Edited" label in the UI.
+    final updatedMessage = Message(
+      id: originalMessage.id,
+      message: newText,


vatsaltanna-simformsolutions · 2026-05-15T09:53:50Z

+```dart
+ChatView(
+  // ...
+  onEditTap: (Message originalMessage, String newText) {


onEditTap seems to be the callback when we click on edit button.

onEditTap is a callback when we click on the edit button. so naming convention looks proper to me.

vatsaltanna-simformsolutions · 2026-05-15T09:54:09Z

+```dart
+ChatView(
+  // ...
+  onEditTap: (Message originalMessage, String newText) {


instead of string we should pass message object only

japanshah-simform · 2026-05-18T07:56:14Z

    this.enableOtherUserName = true,
    this.enableScrollToBottomButton = false,
    this.enableTextSelection = false,
+    this.enableMessageEditing = true,


It should default to false.

…tegration examples

vasu-nageshri requested a review from Copilot May 12, 2026 05:49

Copilot started reviewing on behalf of vasu-nageshri May 12, 2026 05:50 View session

Copilot AI reviewed May 12, 2026

View reviewed changes

vasu-nageshri force-pushed the feature/edit-message-support branch from a427094 to acb9181 Compare May 12, 2026 06:10

vasu-nageshri requested review from dhyash-simform and vatsaltanna May 12, 2026 06:11

vasu-nageshri force-pushed the feature/edit-message-support branch 2 times, most recently from 16e7b32 to 9eedc33 Compare May 12, 2026 09:52

japanshah-simform requested changes May 15, 2026

View reviewed changes

vasu-nageshri force-pushed the feature/edit-message-support branch from 9eedc33 to cfb66dc Compare May 15, 2026 09:15

vasu-nageshri force-pushed the feature/edit-message-support branch from cfb66dc to 372f7aa Compare May 15, 2026 09:21

japanshah-simform self-requested a review May 15, 2026 09:31

japanshah-simform approved these changes May 15, 2026

View reviewed changes

vatsaltanna-simformsolutions reviewed May 15, 2026

View reviewed changes

japanshah-simform reviewed May 18, 2026

View reviewed changes

japanshah-simform force-pushed the feature/edit-message-support branch from 569e1ea to 29252dd Compare May 19, 2026 05:11

feat: Enhance edit message functionality with updated callback and in…

5fcc22f

…tegration examples

japanshah-simform force-pushed the feature/edit-message-support branch from 29252dd to 5fcc22f Compare May 19, 2026 06:26

		/// Displays an "Editing" header with the original message preview and a
		/// close button to cancel the edit.

Conversation

vasu-nageshri commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Breaking Change?

Related Issues

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

japanshah-simform left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

vasu-nageshri commented May 12, 2026 •

edited

Loading