Skip to content

Fix computation of alpha channel for transparent objects #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ManifoldFR merged 2 commits into from
Feb 26, 2026
+5 −4
Merged

Fix computation of alpha channel for transparent objects #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
707e172
shaders/PbrTransparent : fix how accumulation and revealage computed …
ManifoldFR Feb 26, 2026
542d2f7
Update CHANGELOG
ManifoldFR Feb 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Fixed

- Fixed visual effects with SSAO + MSAA. Have SSAO sample from resolved multisampled depth texture (https://github.com/Simple-Robotics/candlewick/pull/105)
- Fix WBOIT transparent shader formulas, fixing transparency visual appearance and alpha channel in PNG screenshots (https://github.com/Simple-Robotics/candlewick/pull/110)

## [0.10.1] - 2026-01-19

Expand Down
4 changes: 2 additions & 2 deletions shaders/compiled/PbrTransparent.frag.msl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ struct KernelContext_0
float weight_0 = clamp((alpha_0 * 10.0 + 0.00999999977648258) * (1.0 - fragCoord_0.z * 0.30000001192092896), 0.00999999977648258, 1000.0);

thread FSOutput_0 output_0;
(&output_0)->accum_0 = float4(pow(uncharted2ToneMapping_0(float3(0.02999999932944775) * mat_0.baseColor_0.xyz * float3(mat_0.ao_0) + Lo_0), float3(0.45454543828964233) ) * float3(alpha_0) * float3(weight_0) , alpha_0);
(&output_0)->reveal_0 = 1.0 - alpha_0 * weight_0;
(&output_0)->accum_0 = float4(pow(uncharted2ToneMapping_0(float3(0.02999999932944775) * mat_0.baseColor_0.xyz * float3(mat_0.ao_0) + Lo_0), float3(0.45454543828964233) ) * float3(alpha_0) * float3(weight_0) , alpha_0 * weight_0);
(&output_0)->reveal_0 = alpha_0;
return output_0;
}
Binary file modified shaders/compiled/PbrTransparent.frag.spv
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions shaders/src/PbrTransparent.frag.slang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ FSOutput main([vk::location(0)] float3 fragViewPos,
float weight = clamp(w1 * (1.0 - z * 0.3), 1e-2, 1e3);

FSOutput output;
output.accum = float4(color * alpha * weight, alpha);
output.reveal = 1.0 - alpha * weight;
output.accum = float4(color * alpha * weight, alpha * weight);
output.reveal = alpha;
return output;
}