[MS-1380] Launch camera setup in viewLifecycleOwner.lifecycleScope#1610
Open
BurningAXE wants to merge 1 commit intomainfrom
Open
[MS-1380] Launch camera setup in viewLifecycleOwner.lifecycleScope#1610BurningAXE wants to merge 1 commit intomainfrom
BurningAXE wants to merge 1 commit intomainfrom
Conversation
… avoid trying to access view after it's been destroyed
There was a problem hiding this comment.
Pull request overview
Fixes a Face Capture crash by moving the camera setup coroutine to the view lifecycle so it gets cancelled when the Fragment’s view is destroyed (e.g., user navigates away mid-setUpCamera()).
Changes:
- Launch
setUpCamera()inviewLifecycleOwner.lifecycleScopeinstead oflifecycleScopeto avoid accessingbindingafteronDestroyView.
You can also share your feedback on Copilot code review. Take the survey.
|
meladRaouf
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2026.2.0
Root cause analysis (for bugfixes only)
First known affected version: since face capture exists!?
setUpCamera()after which the binding is accessedNotable changes
viewLifecycleOwnerfor the whole camera setup coroutine so it's lifecycle safeTesting guidance
Additional work checklist