Skip to content

Sindhu python #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sindhu1702013 merged 6 commits into from
Jan 30, 2026
Merged

Sindhu python #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
abb96ef
Add greeting for factorial input of 0 or 1
Sindhu1702013 Dec 29, 2025
6024ed2
Change greeting from 'Sindhu' to 'Sindhuja'
Sindhu1702013 Jan 30, 2026
677d2e9
Add arithmetic operations in justPrint function
Sindhu1702013 Jan 30, 2026
4db3289
Update Programs/P01_hello.py
Sindhu1702013 Jan 30, 2026
5c4fe06
Update Programs/P01_hello.py
Sindhu1702013 Jan 30, 2026
cb0e366
Merge branch 'master' into sindhu-python
Sindhu1702013 Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Programs/P01_hello.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@
def justPrint(text):
'''This function prints the text passed as argument to this function'''
print(text)
base_value = 10
Copy link
Contributor

@appmod-pr-genie-qa appmod-pr-genie-qa bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical Confidence Score: 95% View Citation

Non-Descriptive Variable Name

The variable name 'a' is a single character and lacks descriptive context. Use a name that reflects the variable's purpose, such as 'base_value' or 'offset'.

Suggested change
base_value = 10
base_value = 10
Reasons & Gaps

Reasons

  1. Single-character names fail to communicate the intent or content of the variable
  2. Descriptive names reduce cognitive load and improve code maintainability
  3. PEP 8 guidelines generally discourage single-letter names except for loop counters

Gaps

  1. Single-letter variables are occasionally used in simple scripts for brevity
  2. The specific mathematical or logical context for 'a' is not fully clear from the diff

b=20
Comment on lines +7 to +8
Copy link
Contributor

@appmod-pr-genie-qa appmod-pr-genie-qa bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JAS Confidence Score: 100%

JAS - Just a suggestion
Unused Local Variables and Dead Logic

I noticed we've added some arithmetic calculations (a, b, c) inside the justPrint function, but these values aren't being used for anything. Since the function's purpose is just to print the provided text, these extra lines don't add any functional value and might confuse other developers. We should probably remove them to keep the function focused and clean.

Copy link
Contributor

@appmod-pr-genie-qa appmod-pr-genie-qa bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical Confidence Score: 95% View Citation

Non-Descriptive Variable Name

The variable name 'b' is non-descriptive. Renaming it to something like 'increment_value' or 'limit' would make the code more self-documenting.

Suggested change
b=20
increment_value = 20
Reasons & Gaps

Reasons

  1. Meaningless names like 'b' require developers to read surrounding logic to understand purpose
  2. Clear naming prevents errors during future refactoring or logic updates
  3. Standardized naming improves consistency across the enterprise codebase

Gaps

  1. The variable might be part of a generic example where 'b' is traditionally used
  2. Project-specific naming conventions for local temporary variables are unknown

difference = increment_value - base_value
Copy link
Contributor

@appmod-pr-genie-qa appmod-pr-genie-qa bot Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical Confidence Score: 100%

Functional Issue: Undefined Reference

The variable increment_value is used in a calculation but has not been defined within the function scope or passed as an argument. This will result in a NameError when the function is executed.

Suggested change
difference = increment_value - base_value
def justPrint(text, increment_value=5):
print(text)
base_value = 10
difference = increment_value - base_value


if __name__ == '__main__':
justPrint('Hello Sindhu12390')
justPrint('Hello Sindhuja')


1 change: 1 addition & 0 deletions Programs/P04_Factorial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ def factorial(number):
if number < 0:
print('Invalid entry! Cannot find factorial of a negative number')
if number == 0 or number == 1:
print("Hello")
return 1
else:
return number * factorial(number - 1)
Expand Down
Loading