Skip to content

skargo: use per-unit state.db to avoid cache thrashing #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cristianoc wants to merge 1 commit into
base: main
Choose a base branch
from
Open

skargo: use per-unit state.db to avoid cache thrashing #1120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion skiplang/skargo/src/build_runner.sk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,11 +391,16 @@ mutable class BuildRunner(
if (!unit.target.is_build_script()) {
// TODO: Once we have namespaced packages, we can share the state.db
// across architectures.
// Also split by unit to avoid cache thrashing between lib and test
Copy link
Copy Markdown
Contributor

@mbouaziz mbouaziz Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Also split by unit to avoid cache thrashing between lib and test
// Also split by unit to avoid cache thrashing between bin and test

// targets that share the same build directory.
unit_hash = this.hashes[unit].toStringHex();
state_db_path = Path.join(
this.layout_for(unit).build,
// FIXME: This is a dirty hack that splits out the state.db between pic
// and static, which is required until `skc` namespaces packages.
`${unit.build_opts.relocation_model}_state.db`,
`${unit.pkg.name()}-${unit_hash}_${
unit.build_opts.relocation_model
}_state.db`,
);
skc.args(
Array[
Expand Down