Zigbee Switch: Add support/handling for Stateless Step Capabilities#2818
Open
Zigbee Switch: Add support/handling for Stateless Step Capabilities#2818
Conversation
|
Invitation URL: |
Test Results 72 files 495 suites 0s ⏱️ Results for commit 3da9241. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 3da9241 |
wkhenon
force-pushed
the
zigbee-switch/stateless-capabilities
branch
2 times, most recently
from
535962c to
cf1fc47
Compare
|
Duplicate profile check: Warning - duplicate profiles detected. |
greens
force-pushed
the
feature/color_temp_range
branch
from
3d5baa4 to
8855768
Compare
wkhenon
force-pushed
the
zigbee-switch/stateless-capabilities
branch
2 times, most recently
from
c0a48c5 to
f4a7af9
Compare
wkhenon
requested review from
aleclorimer,
cjswedes,
greens,
hcarter-775,
nickolas-deboom,
pegor-karoglanian and
tpmanley
greens
reviewed
Mar 4, 2026
drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua
Outdated
Show resolved
Hide resolved
wkhenon
force-pushed
the
zigbee-switch/stateless-capabilities
branch
from
f10a277 to
1bbafc5
Compare
hcarter-775
reviewed
Mar 9, 2026
drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua
Outdated
Show resolved
Hide resolved
wkhenon
force-pushed
the
zigbee-switch/stateless-capabilities
branch
from
1bbafc5 to
21d5850
Compare
greens
reviewed
Mar 10, 2026
drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua
Outdated
Show resolved
Hide resolved
hcarter-775
reviewed
Mar 11, 2026
drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua
Outdated
Show resolved
Hide resolved
wkhenon
force-pushed
the
zigbee-switch/stateless-capabilities
branch
from
4ad4ca3 to
75ef0dc
Compare
greens
reviewed
Mar 11, 2026
drivers/SmartThings/zigbee-switch/src/stateless_handlers/init.lua
Outdated
Show resolved
Hide resolved
greens
reviewed
Mar 11, 2026
drivers/SmartThings/zigbee-switch/src/stateless_handlers/can_handle.lua
Outdated
Show resolved
Hide resolved
wkhenon
force-pushed
the
zigbee-switch/stateless-capabilities
branch
from
671071f to
2023b46
Compare
greens
approved these changes
Mar 12, 2026
hcarter-775
force-pushed
the
zigbee-switch/stateless-capabilities
branch
from
2023b46 to
2a1d09d
Compare
hcarter-775
approved these changes
Mar 26, 2026
tpmanley
reviewed
Mar 26, 2026
tpmanley
reviewed
Mar 26, 2026
tpmanley
reviewed
Mar 30, 2026
| switch_utils.KELVIN_MAX = "_max_kelvin" | ||
| switch_utils.KELVIN_MIN = "_min_kelvin" | ||
| switch_utils.MIREDS_CONVERSION_CONSTANT = 1000000 | ||
| switch_utils.COLOR_TEMPERATURE_KELVIN_MAX = 15000 |
Contributor
There was a problem hiding this comment.
I think we need to adjust these max/min's similar to what you did or were going to do for Matter
Contributor
There was a problem hiding this comment.
The Matter change (seen here) does not actually alter the max/min values- only the defaults used as max and min for the step level.
One reason I haven't done that in this PR is because I'm not sure what the correct default should be. In matter there is a relatively clear default from my perspective, but not here.
Contributor
There was a problem hiding this comment.
I think the same range would be fine to use here. It's going to be closer to reality than 1000-15000
tpmanley
reviewed
Mar 30, 2026
| local function step_color_temperature_by_percent_handler(driver, device, cmd) | ||
| local step_percent_change = cmd.args and cmd.args.stepSize or 0 | ||
| if step_percent_change == 0 then return end | ||
| local step_mode = step_percent_change > 0 and clusters.ColorControl.types.CcStepMode.DOWN or clusters.ColorControl.types.CcStepMode.UP |
Contributor
There was a problem hiding this comment.
It'd be helpful to add a comment here that a step up in Kelvin is a step down in mireds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests