Skip to content

Revert "Support DPS feature (#2750)"#2859

Merged
ctowns merged 1 commit intomainfrom
revert-dps
Mar 31, 2026
Merged

Revert "Support DPS feature (#2750)"#2859
ctowns merged 1 commit intomainfrom
revert-dps

Conversation

@ctowns
Copy link
Copy Markdown
Contributor

@ctowns ctowns commented Mar 30, 2026

This reverts commit edfba7e.

Issues with DPS were discovered while testing in beta. This will revert the commit in main, which can then be cherry-picked to beta. This should help to prevent merge conflicts from main -> beta.

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

@github-actions
Copy link
Copy Markdown

Duplicate profile check: Warning - duplicate profiles detected.
lock-modular-embedded-unlatch.yml == lock-modular.yml

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

Channel deleted.

@ctowns
Copy link
Copy Markdown
Contributor Author

ctowns commented Mar 30, 2026

Currently set this up to revert from main and then we can cherry-pick the revert into beta to keep the git history a little cleaner when we start merging main -> beta again, but I am open to just reverting directly in beta and then merging down as needed later if that would be preferred. I think this is a little cleaner and allows us to also fix main using the same process we have used in the past.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

Test Results

   72 files    494 suites   0s ⏱️
2 703 tests 2 703 ✅ 0 💤 0 ❌
4 571 runs  4 571 ✅ 0 💤 0 ❌

Results for commit 30ec193.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

File Coverage
All files 80%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 68%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lazy_load_subdriver.lua 57%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 77%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/can_handle.lua 90%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 30ec193

This reverts commit edfba7e. Also
removes the 'IS_MODULAR_PROFILE' field which is no longer needed.
@ctowns ctowns requested a review from HunsupJung March 30, 2026 20:34
@ctowns ctowns merged commit dbaa2e1 into main Mar 31, 2026
12 checks passed
@ctowns ctowns deleted the revert-dps branch March 31, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants