Skip to content

Revert "Support DPS feature (#2750)"#2863

Merged
ctowns merged 1 commit intobetafrom
cherry-pick/beta-2026-03-31
Mar 31, 2026
Merged

Revert "Support DPS feature (#2750)"#2863
ctowns merged 1 commit intobetafrom
cherry-pick/beta-2026-03-31

Conversation

@ctowns
Copy link
Copy Markdown
Contributor

@ctowns ctowns commented Mar 31, 2026

Cherry pick 30ec193 from main -> beta:

This reverts commit edfba7e. Also removes the 'IS_MODULAR_PROFILE' field which is no longer needed.

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

This reverts commit edfba7e. Also
removes the 'IS_MODULAR_PROFILE' field which is no longer needed.
@github-actions
Copy link
Copy Markdown

Duplicate profile check: Warning - duplicate profiles detected.
lock-modular-embedded-unlatch.yml == lock-modular.yml

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 31, 2026

Channel deleted.

@github-actions
Copy link
Copy Markdown

Test Results

   72 files    493 suites   0s ⏱️
2 573 tests 2 573 ✅ 0 💤 0 ❌
4 408 runs  4 408 ✅ 0 💤 0 ❌

Results for commit 851da69.

@github-actions
Copy link
Copy Markdown

File Coverage
All files 80%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/can_handle.lua 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/new-matter-lock/init.lua 77%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lazy_load_subdriver.lua 57%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-lock/src/lock_utils.lua 68%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 851da69

Copy link
Copy Markdown
Contributor

@tpmanley tpmanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this with the Yale lock that supports DPS and confirmed the DPS feature isn't exposed, and also confirmed other functionality like PIN code setup and schedules

@ctowns ctowns merged commit 1530a44 into beta Mar 31, 2026
12 checks passed
@ctowns ctowns deleted the cherry-pick/beta-2026-03-31 branch March 31, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants