Remove use of StandardCharsets due to incompatibility with older Java…#216
Merged
jimirocks merged 1 commit intoSmarteon:masterfrom Oct 26, 2025
Merged
Remove use of StandardCharsets due to incompatibility with older Java…#216jimirocks merged 1 commit intoSmarteon:masterfrom
jimirocks merged 1 commit intoSmarteon:masterfrom
Conversation
Contributor
|
thx for contribution, but this project migrated to Java 11 long time ago, so even the build is not binary compatible with older versions than 11. So in this perspective what meaning could have this change? May be if supporting some older JVMs is desired - more changes are needed then? |
Contributor
Author
|
@jimirocks i use the library in an Android application. This also is compiled with Java 11, but the StandardCharsets encoder method for URLEncoder doesn't seem to exist on Android. All the other functionality works normal. So I think this small change is acceptable to make the code compatible on Android |
Contributor
|
Ahh thx for context. The android is kind of different than JVM |
jimirocks
approved these changes
Oct 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… versions (<10)