refactor: use keyword-only arguments#342
Conversation
Documentation build overview
9 files changed ·
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates numerous function signatures across the codebase to enforce keyword-only arguments by introducing the * separator. A review comment was provided identifying an inconsistency in the type hinting for the size parameter in src/pystatpower/models/correlation/inequality.py, where it is currently typed as an int instead of a float, and a code suggestion was provided to align it with other functions in the module.
| def solve_null_correlation( | ||
| *, | ||
| correlation: float, | ||
| size: int, |
There was a problem hiding this comment.
The size parameter is typed as int here, but it is typed as float in other functions within the same file (e.g., solve_power and solve_correlation). For consistency across the module, it should be typed as float.
| size: int, | |
| size: float, |
1 participant
No description provided.