feat: render HTML-only emails as readable text in mail read#9
Merged
Conversation
Reading an HTML-only message previously dumped raw markup (<html>, inline <style>, etc.). Add HTMLToText (x/net/html): it strips script/style/head, inserts line breaks around block elements, unescapes entities, and collapses whitespace. A new Message.DisplayBody() prefers a genuine text/plain part and only renders HTML when that's all there is. Wired into the table and plain (human) formatters only — JSON output keeps raw body/html_body so it stays lossless for scripting. Adds unit tests for HTMLToText and DisplayBody. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mail readon an HTML-only message used to print raw markup (<html>, inline<style>, scripts). This renders it as clean readable text instead.HTMLToText(internal/yahoo/html.go, viagolang.org/x/net/html): dropsscript/style/head/title/noscript, inserts line breaks around block-level elements and<br>, unescapes entities, and collapses whitespace.Message.DisplayBody(): prefers a genuinetext/plainpart; only renders HTML when that's the sole body. RawBody/HTMLBodyare untouched.body/html_bodypreserved for scripting).HTMLToText(script/style stripping,<br>, entities) andDisplayBody(plain-preferred, HTML fallback).Verification
gofmt/go vet/go buildclean;go test ./...green.--jsonstill returns raw HTML inbody/html_body.🤖 Generated with Claude Code