Skip to content

Fix GitHub OAuth sign-in redirect#1262

Open
398724221 wants to merge 1 commit into
SolFoundry:mainfrom
398724221:fix-github-oauth-signin-flow
Open

Fix GitHub OAuth sign-in redirect#1262
398724221 wants to merge 1 commit into
SolFoundry:mainfrom
398724221:fix-github-oauth-signin-flow

Conversation

@398724221
Copy link
Copy Markdown

Summary

  • Fixes 🏭 Bounty T1: Fix GitHub OAuth Sign-In Flow #821
  • Centralizes GitHub sign-in redirects through one OAuth helper
  • Falls back to the official GitHub authorize URL when /api/auth/github/authorize is unavailable, instead of redirecting users to a 404-prone relative API route
  • Adds client-side OAuth state generation/storage and callback state validation before exchanging the code
  • Replaces remaining hard-coded /api/auth/github/authorize sign-in entry points
  • Adds missing shared frontend utility modules required for the production build

Verification

  • npm test -- auth.test.ts --run
  • npm run build
  • git diff --check

Notes

  • npm test -- --run still fails on existing baseline issues unrelated to this PR: missing Playwright dependency for frontend/tests/e2e/* and many existing tests importing components/modules that are not present in the repo. The focused OAuth tests and production build pass.

Bounty

Submitting for the T1 bounty in #821. Payout details can be coordinated after review/merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

missing-wallet PR is missing a Solana wallet for bounty payout

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🏭 Bounty T1: Fix GitHub OAuth Sign-In Flow

1 participant