Add web admin feature and improve tool invocation#17
Conversation
Sophomoresty
left a comment
There was a problem hiding this comment.
Thanks for the effort — the admin UI looks polished and the session stats implementation is solid (atomic writes, thread-safe, HMAC sessions).
A few things to address before merging:
-
Please split this PR — tool calling improvements and the web admin feature are independent concerns. Smaller PRs are easier to review and bisect.
-
server.py grew from ~100 to ~1000 lines — the admin routes, session management, and stats logic should live in separate modules (e.g.
admin_routes.py,session_stats.py). -
Default credentials in config.example.json —
admin/adminis risky for users who deploy without reading docs. Consider requiring initial setup or generating a random password on first run. -
Session secret — when
session_secretis None, a random value is generated at startup, which invalidates all sessions on restart. This is fine but should be documented explicitly. -
Commit authorship — the commit is authored by "Codex Bot". For contribution attribution, please use your own git identity.
Happy to re-review once these are addressed.
新增web展示页面

参考其他项目优化工具调用