feat: implement api crud for brand and theme color#25
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new organization_setting application to manage organization-specific settings and themes (light and dark). It includes database models, serializers, views, URLs, a backfill migration, and integrates settings into the bootstrap process and organization API. The review feedback highlights several critical issues: a potential TypeError in the serializer's _get_instance method when no default is provided, a likely IntegrityError during bulk_create due to missing UUID generation, dead lookup code caused by read-only nested id fields, an anti-pattern of importing application services inside a migration, and a lack of validation for the X-Organization header in the settings view.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
What?
Implement API crud for brand and theme color
Why?
How?
Testing?
Anything Else?