Feat/new protocol frontend#9
Open
SpaceFox1 wants to merge 15 commits into
Open
Conversation
Rebase feat/prettier-frontend to sync with main branch
Sync frontend with Feat/new protocol
…-protocol-frontend
Implement logo.png and color.txt on backend
…-protocol-frontend
kitsuvm
requested changes
Apr 22, 2026
Collaborator
There was a problem hiding this comment.
File is named WebRTCManager but the class inside it is named as WRTCManager, is a typo?
Collaborator
There was a problem hiding this comment.
I think is better to rename this file to follow PascalCase from WebRTCManager.
| }); | ||
| } | ||
|
|
||
| onMount(() => { |
Collaborator
There was a problem hiding this comment.
Migrate from onMount and onDestroy to $effect with desconstructor.
| import { ClientToServer, type ServerToClient } from "$lib/protos/streamer"; | ||
| import type { Session } from "$lib/interfaces/session"; | ||
|
|
||
| // svelte-ignore non_reactive_update |
| break; | ||
| } | ||
| } | ||
| onMount(() => { |
| "check": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json", | ||
| "check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch", | ||
| "lint": "eslint .", | ||
| "proto": "protoc --proto_path=../protos --plugin=./node_modules/.bin/protoc-gen-ts_proto --ts_proto_out=./src/lib/protos ../protos/controller.proto ../protos/streamer.proto ../protos/viewer.proto" |
Collaborator
There was a problem hiding this comment.
Isn't better rename this to proto:build?
| }, | ||
| kit: { | ||
| adapter: adapter(), prerender: { | ||
| handleHttpError: 'warn', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.