V1.0.8#21
Merged
Merged
Conversation
Shell variables interpolated directly into inline Python source caused unterminated string literals when the address contained control characters. Fixes #20. Changes: - Use os.environ instead of shell interpolation in all three entrypoint scripts (run.sh, entrypoint.sh, run-local.sh) - Strip control characters from ip route output with tr -d '[:cntrl:]'
There was a problem hiding this comment.
Pull request overview
This PR updates the project to release v1.0.8, ensuring version metadata is consistent across packaging, add-on manifests, and lockfiles, while also hardening TLS certificate generation scripts by avoiding shell string interpolation issues.
Changes:
- Bump version from 1.0.7 → 1.0.8 across Python package metadata, add-on metadata, and lockfile.
- Harden certificate generation in shell entrypoints by reading
ADVERTISE_ADDRESS/CERT_DIRfrom environment in Python (and stripping control chars from detected IP in the add-on run script). - Ignore generated rates cache file in
.gitignore.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
uv.lock |
Updates locked editable package version to 1.0.8. |
src/span_panel_simulator/__init__.py |
Bumps __version__ constant to 1.0.8. |
span_panel_simulator/run.sh |
Sanitizes detected IP and passes cert params via env to Python to avoid string-literal issues. |
span_panel_simulator/Dockerfile |
Updates Home Assistant add-on label version to 1.0.8. |
span_panel_simulator/config.yaml |
Updates add-on config version to 1.0.8. |
scripts/run-local.sh |
Passes cert params via env to Python for local runs. |
scripts/entrypoint.sh |
Exports env vars and reads them in Python for cert generation. |
pyproject.toml |
Updates project version to 1.0.8. |
.gitignore |
Ignores configs/rates/rates_cache.yaml. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.