Skip to content

<Avatar> dimensions and screen reader text #2206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abovedave wants to merge 4 commits into
base: develop
Choose a base branch
from
+20 −4
Open

<Avatar> dimensions and screen reader text #2206

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15a12de
add dimensions using size variable
abovedave Mar 4, 2026
534b347
address A11Y-126 by adding a title tag to the icon
abovedave Mar 4, 2026
bad74aa
format
abovedave Mar 4, 2026
843fa0d
changeset
abovedave Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/strong-news-float.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@stackoverflow/stacks-svelte": patch
---

* `<Avatar>` nested `<img>` dimensions.
* Screen reader text for the private badge variant.
18 changes: 14 additions & 4 deletions packages/stacks-svelte/src/components/Avatar/Avatar.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,14 +82,24 @@
{...restProps}
>
{#if src}
<img class="s-avatar--image" {src} alt="" role="presentation" />
<img
class="s-avatar--image"
{src}
alt=""
role="presentation"
width={size}
height={size}
/>
{:else if letter}
<span class="s-avatar--letter" aria-hidden="true">{letter}</span>
{/if}
<span class="v-visible-sr">{name}</span>
{#if badge}
<!-- TODO This badge is not purely decorative, so it should include descriptive text
(see https://stackoverflow.atlassian.net/browse/A11Y-126) -->
<Icon class="s-avatar--badge" src={IconShieldXSm} native />
<Icon
class="s-avatar--badge"
src={IconShieldXSm}
native
title="Private"
/>
{/if}
</svelte:element>