Skip to content

fix(skill-build): use --host/--port for thv serve and correct health-check path #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChrisJBurns merged 1 commit into from
Jun 17, 2026
Merged

fix(skill-build): use --host/--port for thv serve and correct health-check path #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ on:
pull_request:
branches: [ main ]
workflow_dispatch:
# Run daily so breakage from upstream ToolHive "latest" releases (e.g. renamed
# CLI flags or moved API routes) is caught proactively rather than at next push.
schedule:
- cron: '0 6 * * *'

jobs:
test-install-action:
Expand Down
11 changes: 7 additions & 4 deletions skill-build/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,12 @@ runs:
id: daemon
shell: bash
run: |
# Check if a daemon is already reachable (e.g., started by run-mcp-server)
# Check if a daemon is already reachable (e.g., started by run-mcp-server).
# Any HTTP response (even 503 when no container runtime is present) means the
# API server is up. Skill build/push package OCI artifacts and do not require
# a container runtime, so we must not gate readiness on the runtime's health.
EXISTING_URL="${TOOLHIVE_API_URL:-http://127.0.0.1:8080}"
if curl -sf "${EXISTING_URL}/api/v1beta/health" > /dev/null 2>&1; then
if [ "$(curl -s -o /dev/null -w '%{http_code}' "${EXISTING_URL}/health" 2>/dev/null)" != "000" ]; then
echo "ToolHive daemon already running at $EXISTING_URL"
PORT=$(echo "$EXISTING_URL" | sed -E 's|.*://[^:]+:([0-9]+).*|\1|')
echo "port=$PORT" >> $GITHUB_OUTPUT
Expand All @@ -67,7 +70,7 @@ runs:
}

echo "Starting thv serve on port $PORT..."
thv serve --address "127.0.0.1:${PORT}" &
thv serve --host "127.0.0.1" --port "${PORT}" &
DAEMON_PID=$!
echo "pid=$DAEMON_PID" >> $GITHUB_OUTPUT
echo "port=$PORT" >> $GITHUB_OUTPUT
Expand All @@ -82,7 +85,7 @@ runs:
wait "$DAEMON_PID" 2>/dev/null
exit 1
fi
if curl -sf "http://127.0.0.1:${PORT}/api/v1beta/health" > /dev/null 2>&1; then
if [ "$(curl -s -o /dev/null -w '%{http_code}' "http://127.0.0.1:${PORT}/health" 2>/dev/null)" != "000" ]; then
echo "ToolHive daemon is ready (port $PORT)"
break
fi
Expand Down
Loading