Add generic type parameter for Round state#4
Open
giokaxo wants to merge 1 commit intoStakeEngine:mainfrom
Open
Add generic type parameter for Round state#4giokaxo wants to merge 1 commit intoStakeEngine:mainfrom
giokaxo wants to merge 1 commit intoStakeEngine:mainfrom
Conversation
The `Round.state` field was typed as `unknown`, forcing consumers to cast manually. This adds a generic `<T = unknown>` to `Round`, `PlayResponse`, `AuthenticateResponse`, `Client`, and `RGSClient` so the state type can be specified once and flow through the entire API. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<T = unknown>toRound,PlayResponse,AuthenticateResponse,Client, andRGSClientround.stateinstead of it being hardcoded tounknownunknownwhen no type argument is providedProblem
The
Round.statefield was typed asunknown, requiring consumers to manually cast the state on every access:Solution
The generic parameter flows end-to-end from
RGSClient<T>throughClient<T>,AuthenticateResponse<T>,PlayResponse<T>, andRound<T>:Test plan
= unknowndefault)round.state🤖 Generated with Claude Code