feat: per-release welcome notification for the 0.4.0 line#3402
Open
MattDHill wants to merge 2 commits into
Open
feat: per-release welcome notification for the 0.4.0 line#3402MattDHill wants to merge 2 commits into
MattDHill wants to merge 2 commits into
Conversation
Add a "Welcome to beta.10" notification, shown only to servers already on the 0.4.0 line; servers upgrading from 0.3.x still receive only the "Welcome to 0.4.0" notification. The routing (should_welcome_to_release) is reusable, so a future release won't double-notify on a multi-version jump. - Add the beta.10 highlights (backups v2 guidance first), with a new-tab link to the full changelog. - Refresh the 0.4.0 update notes for stale claims: start-fs -> backup-fs, RISC-V now supported, registry binaries served from a CDN (GitHub mirror), automatic gateway port-forwarding, and a dead backup cross-reference; advise starting services until healthy before backing up. - Add a comment-style rule to AGENTS.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dr-bonez
requested changes
Jul 4, 2026
| server_info.get_mut("postInitMigrationTodos") | ||
| } | ||
|
|
||
| /// True when this run has migrated a version <= `0.4.0-alpha.0`, i.e. the server came |
Member
There was a problem hiding this comment.
I'd prefer this and the following function to be in the beta.10 version file. The current placement implies this is less of a one-off thing than it is
Member
Author
There was a problem hiding this comment.
Done — moved both migrated_from_pre_0_4_0 and should_welcome_to_release (plus the welcome_routing test) into v0_4_0_beta_10.rs; mod.rs is back to just the migration engine. Behavior unchanged. (6dc36d7)
Per review: migrated_from_pre_0_4_0 and should_welcome_to_release are beta.10-specific, not general migration facilities, so they belong with the version that uses them rather than in version/mod.rs. Behavior and the welcome_routing test are unchanged (the test moves with them). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dr-bonez
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a per-release welcome notification for the 0.4.0 line and refreshes the aging 0.4.0 update notes.
Welcome routing (
shared-libs/crates/start-core/src/version/)should_welcome_to_release(version, from_pre_0_4_0)inversion/mod.rs: a welcome fires only for the release actually being landed on (the current head) and only when the server was already on the 0.4.0 line. This keeps a future beta.11 from double-notifying on a beta.9 → beta.11 jump. Covered byversion::tests::welcome_routing.beta.10 highlights (
update_details/v0_4_0_beta_10.md, new)0.4.0 update-notes refresh (
update_details/v0_4_0.md)start-fs→backup-fs; RISC-V RVA23 now supported (present tense); registry binaries served from a CDN with a GitHub mirror; automatic gateway port-forwarding in the clearnet section; rename the "LAN Port Forwarding" heading (it collided with the real auto port-forwarding feature); drop a dead backup cross-reference.AGENTS.md
Verified:
cargo check -p start-coreclean;version::tests::welcome_routingand the existingv0_4_0_beta_10tests pass.🤖 Generated with Claude Code