Nightly2main 2025/10/10#127
Closed
JacksonTheMaster wants to merge 30 commits into
Closed
Conversation
….go so we don't slip on those zips apparently zips are a slippery slope, ok I'll stop now 🤣
fix: ensure run_bepinex.sh is removed only on Linux if it exists
This is attempt 2 to fix path traversal issues within steamcmd-helper… working still as expected
…individually getting the state, reducing load on the backend.
Co-authored-by: JLangisch <jakob.langisch@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…nd adjust JWT generation accordingly. Defaults to 1 month if user sends a GET instead.
Feat server advertisement
APIKeys & Monitoring
The race condition between writing to the Http2 Response Writer occurs
when SSE connection is closed, but the Fprintf formatting code is still
executing.
```
panic: Write called after Handler finished
goroutine 9953 [running]:
net/http.(*http2responseWriter).write(0x2?, 0xc0000944e0?, {0xc000096500?, 0x7ff6153450be?, 0x7ff615d95060?}, {0x0?, 0xc000500808?})
/usr/local/go/src/net/http/h2_bundle.go:6987 +0x13f
net/http.(*http2responseWriter).Write(0xc0000944e0?, {0xc000096500?, 0xa?, 0xc000391f50?})
/usr/local/go/src/net/http/h2_bundle.go:6976 +0x2a
fmt.Fprintf({0x2426bb5a1a0, 0xc0001982d0}, {0x7ff61584992c, 0xa}, {0xc000391f50, 0x1, 0x1})
/usr/local/go/src/fmt/print.go:225 +0x97
github.com/JacksonTheMaster/StationeersServerUI/v5/src/core/ssestream.(*SSEManager).streamMessages(0x0?, {0x7ff6159deac0, 0xc0001982d0}, {0x2426b765b58, 0xc0001982d0}, 0xc0001708a0, {0x0?, 0x0?}, 0xc0002f0150)
src/core/ssestream/ssemanager.go:113 +0x1b6
created by github.com/JacksonTheMaster/StationeersServerUI/v5/src/web.GetLogOutput.StartConsoleStream.(*SSEManager).CreateStreamHandler.func1 in goroutine 9952
src/core/ssestream/ssemanager.go:93 +0x409
```
This is due to concurrent closing of the underlaying Http2 Response Writer and Formatting message
Reproducer via artificial delay:
```
for {
select {
case msg := <-client.messages:
time.Sleep(300 * time.Millisecond)
_, err := fmt.Fprintf(w, "data: %s\n\n", msg)
if err != nil {
logger.SSE.Error(" ❌ Failed to send message: " + err.Error())
return
}
flusher.Flush()
case <-notify:
return
}
}
```
Bugfix 20250150 - SSCM Crash
Fix race condition in SSE handling
…d hardcode in config package for improved maintainability Co-authored-by: mitoskalandiel <mitoskalandiel@gmail.com>
Co-authored-by: mitoskalandiel <mitoskalandiel@gmail.com>
| // Sleep for 30 seconds to follow the standard advertisement timer | ||
| time.Sleep(30 * time.Second) | ||
| } | ||
| }() |
Member
Author
There was a problem hiding this comment.
@akirilov the advertiser should be a singleton and wait on a channel / have some way of stopping it and possibly reloading it. The current implementation will advertise the wrong / default / previous server state (config settings) instead of reloading on config change.
Eg
Suggested change
| }() | |
| }(advertiser) |
Member
Author
There was a problem hiding this comment.
should also then be added to loader.ReloadBackend()
JacksonTheMaster
force-pushed
the
nightly
branch
from
2e3f728 to
7f20a99
Compare
Contributor
|
closed as per VC with @JacksonTheMaster (due to git-filter-repo) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.