Feat advertiser modes#135
Conversation
akirilov
requested review from
JacksonTheMaster and
Copilot
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the advertiser configuration to support multiple IP resolution modes. The OverrideAdvertisedIp setting has been renamed to AdvertiserOverride to better reflect its enhanced functionality, which now includes auto-detection via ipify, direct IPv4 usage, and DNS resolution.
Key changes:
- Renamed all references from
OverrideAdvertisedIptoAdvertiserOverridethroughout the codebase - Added IP resolution logic supporting "auto" mode (ipify), direct IPv4, and DNS lookup
- Updated command-line flag from
-OverrideAdvertisedIpto-AdvertiserOverride
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/advertiser/advertiser.go | Added getIpFromAdvertiserOverride function to handle IP resolution logic for auto/DNS/IPv4 modes |
| src/config/vars.go | Renamed configuration variable from OverrideAdvertisedIp to AdvertiserOverride |
| src/config/getters.go | Updated getter function name to GetAdvertiserOverride |
| src/config/setters.go | Updated setter function name to SetAdvertiserOverride |
| src/config/config.go | Updated JSON field name and environment variable to match new naming |
| src/core/loader/cmdargs.go | Renamed command-line flag from OverrideAdvertisedIp to AdvertiserOverride |
| src/core/loader/loader.go | Updated function call to use new getter name |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@JacksonTheMaster ready for a review |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
New Features: