Docker and Docker-Compose Refactor#80
Closed
1Solon wants to merge 3 commits into
Closed
Conversation
Added Github CodeQL out of pure curiosity about the feature, might remove later
electron was leftover from steamserverui and is not needed in this repo
…and multi-stage build process
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Docker and Docker-Compose setup to improve security, performance, and maintainability. It introduces a multi-stage build process with layer caching optimization and implements rootless containers for enhanced security.
- Removes Electron desktop application entirely and associated dependencies
- Implements multi-stage Docker build with separate frontend and Go compilation stages
- Adds GitHub CodeQL workflow for security analysis
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/package.json | Removes Electron dependencies and build scripts, bumps version to v5.6.4 |
| frontend/main.cjs | Complete removal of Electron main process file (458 lines deleted) |
| compose.yml | Adds named volumes for data persistence and additional mount points for configuration |
| Dockerfile | Refactored to multi-stage build with rootless user, separate frontend/Go build stages |
| .github/workflows/codeql.yml | Adds GitHub CodeQL security analysis workflow for Go and JavaScript |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
Author
|
Whoops, I did EXACTLY what you told me not to, let me remake that :P |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the existing Dockerfile with:
( Now you can add rootless container as another security buzzword! ;> )
Additionally, I've changed the docker-compose to take advantage of the above- and also included some volume configuration, in particular:
Including the volume (and the mount overrides) allows us to maintain persistence between restarts, and also maintains performance (mounts are notorious for killing file i/o)
Changes