Fix world name spaces#87
Closed
akirilov wants to merge 10 commits into
Closed
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Configures Rennovate (dependency updater)
…ore in runtime config feature request MrDrummer25
Contributor
Author
|
Ooops should be to nightly |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds version detection functionality to the game server detection system and fixes world name validation to prevent spaces in world names.
- Adds event handling for version extraction from game server logs
- Implements validation to block world creation with spaces in the name
- Updates GitHub URL reference and version number
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/managers/detectionmgr/types.go | Adds new EventVersionExtracted event type |
| src/managers/detectionmgr/handlers.go | Implements handler for version extraction events |
| src/managers/detectionmgr/detector.go | Adds regex pattern matching for version detection |
| src/config/vars.go | Adds ExtractedGameVersion runtime variable |
| src/config/setters.go | Adds setter function for extracted game version |
| src/config/getters.go | Adds getter function for extracted game version |
| src/config/config.go | Bumps version from 5.6.5 to 5.6.6 |
| src/core/loader/terminalmsg.go | Updates GitHub organization URL |
| renovate.json | Adds complete Renovate configuration |
| UIMod/onboard_bundled/twoboxform/twoboxform.js | Adds validation to prevent spaces in world names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| version := matches[1] | ||
| d.triggerEvent(Event{ | ||
| Type: EventVersionExtracted, | ||
| Message: fmt.Sprintf("Version %s detected", version), |
There was a problem hiding this comment.
[nitpick] The message format duplicates the version display logic from the handler. Consider using just the version string as the message to avoid redundancy, since the handler already formats it as 'Version %s detected'.
Suggested change
| Message: fmt.Sprintf("Version %s detected", version), | |
| Message: version, |
Comment on lines
+141
to
+146
| // If the world type contains a space, it's invalid | ||
| if (primaryValue.includes(' ')) { | ||
| showNotification('The world type cannot contain spaces!', 'error'); | ||
| hidePreloader(); | ||
| return; // Prevent submission | ||
| } |
There was a problem hiding this comment.
The comment on line 141 has a trailing space that should be removed for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Bugfixes