fix(launch): split /C argv + Vanessa JUnit overlay (TASK-127 verification)#4
Merged
Merged
Conversation
`/C"value"` was passed as a single argv element with literal `"` chars in the payload — `std::process::Command` bypasses the shell on both Linux (execve) and Windows (CreateProcess), so the platform received `/C"…"` as one unknown key and replied with «Неверные или отсутствующие параметры соединения с информационной базой». Splitting into `/C` and the payload as two argv tokens makes the platform parse `/C` as the command-line parameter key and the next token as its value. Tests adjusted to match the new format: argv pairs `["/C", "<value>"]` in unit tests and `/C\n<value>\n` in the integration args.log dump (printf '%s\n' "$@" puts each argv on its own line). Recovered from a dangling stash (cdb1e0a0 "fix/c-arg-quoting WIP") that had been authored locally but never committed; rebuilds lost the patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick двух фиксов для
v8-runner test vaна путях с пробелами:95b58d2 fix(launch): split /C and payload into separate argv tokens(наш собственный, восстановлен из stash 13.05). Возвращает/C+ payload двумя argv вместо/C"payload"одним. Снимает блокер «Неверные или отсутствующие параметры соединения с информационной базой» на Linux, когда payload содержит пробелы (наш репозиторий:1C Projects/GBIG PAM).008e200 Fix Vanessa JUnit report directory overlay(cherry-pick из upstream alkoleft/v8-runner-rust PR Исправление ошибок запуска Yaxunit и VA тестов alkoleft/v8-runner-rust#6, автор Oleg Karataev). СинхронизируетКаталогВыгрузкиJUnitиОтчетJUnit.КаталогВыгрузкиJUnitв runtime VAParams. Без этого VA пишет junit вbuild/out/junit, runner ждёт вruns/<id>/junit.Контекст
Регрессия выявлена при верификации TASK-127 (маппинг русских/английских OKX-перечислений) через сценарий
S123-покупка-btc-5процентов-висяк.feature. После пересборки бинаряv8-runner test vaстабильно падал. Диагностика через strace + manual 1cv8c с теми же argv: на Linux 1cv8c не парсит payload внутри/C\"...\"одиночного argv при пробелах в пути.Upstream PR alkoleft#6 описывает баг как Windows-специфический (CMD escape), но он одинаково ломается на Linux при пробелах.
Test plan