Feat/asset tag service#578
Open
Yusufolosun wants to merge 2 commits into
Open
Conversation
|
@Yusufolosun Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| metadata: { name: tag.name }, | ||
| }); | ||
|
|
||
| logger.info({ tagId: tag.id, name: tag.name, performedBy }, "Asset tag created successfully"); |
| metadata: { changes: updateData }, | ||
| }); | ||
|
|
||
| logger.info({ tagId: id, performedBy }, "Asset tag updated successfully"); |
| metadata: { name: existing.name }, | ||
| }); | ||
|
|
||
| logger.info({ tagId: id, name: existing.name, performedBy }, "Asset tag deleted successfully"); |
| metadata: { assetSymbol, tagId: tag.id, tagName: tag.name }, | ||
| }); | ||
|
|
||
| logger.info({ assetSymbol, tagName: tag.name, performedBy }, "Asset tag assigned successfully"); |
| resourceId: asset.id, | ||
| metadata: { assetSymbol, tagId: tag.id, tagName: tag.name }, | ||
| }); | ||
| logger.info({ assetSymbol, tagName: tag.name, performedBy }, "Asset tag unassigned successfully"); |
| }); | ||
|
|
||
| logger.info( | ||
| { assetSymbolsCount: assetSymbols.length, tagNamesCount: tagNames.length, assignedCount, performedBy }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #509
Summary
Implements the internal Asset Tag Service with full CRUD operations, bulk assignment, audit logging, search integration, and API endpoints.
Changes
Database
027_asset_tag_service.tsmigration definingtagsandasset_tagsschemas with UUID constraints, unique keys, cascaded deletions, and index mappingsModel
tag.model.tswith Knex-based CRUD helpersBusiness Logic
assetTag.service.tswith validation logic, database queries, bulk transactions, andauditServiceintegrationaudit.service.tsto support tag audit action type safetySearch & Filtering
search.service.tsto index asset tags into search documents and enable JSONB filtering by single or multiple tagsAPI Routes
assets.tsto expose:GET /tags,GET /tags/:id,GET /:symbol/tagsPOST /tags,PUT /tags/:id,DELETE /tags/:id,POST /tags/bulk-assign,POST /:symbol/tags,DELETE /:symbol/tags/:tagNamesource("api-key" | "bootstrap") to audit logactorType("api_key" | "system")Testing
assetTag.service.test.ts— 9/9 unit tests pass (CRUD, validation, bulk assignment, audit triggers)assetTags.test.ts— 11/11 integration tests pass (routes, auth, public permissions, param validation)npx tsc --noEmit— 0 compilation errors