feat: add addrecipient() to append a recipient before payment#128
Closed
Sundriveauto wants to merge 4 commits into
Closed
feat: add addrecipient() to append a recipient before payment#128Sundriveauto wants to merge 4 commits into
Sundriveauto wants to merge 4 commits into
Conversation
Allows the creator to call addrecipient() on a pending invoice as long as no payment has been received yet (funded == 0). Appends the new recipient and amount to the parallel recipients/amounts/tokens/claimed vecs, emits a recipient_added event, and writes an audit entry.
|
@Sundriveauto Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Emits a structured invoice_completed event from _release_full (both main release and group-member release) and _release_tranches when an invoice's status becomes Released. The payload includes invoice_id, creator, total, recipient_count, and completion_timestamp so off-chain systems can process completions without polling.
If refund() detects the contract token balance is insufficient to repay payers (e.g. due to a contract bug draining funds), it draws from the insurance_pool deposited by the creator at invoice creation. Emits an insurance_used event with shortfall and remaining pool details. On cancel, release, or normal refund, unused insurance is returned to the creator.
…ents schedule_pay() registers a payment intent at a specific future ledger timestamp, consuming the nonce to prevent double-use. A separate execute_scheduled_pay() call processes the transfer once the timestamp is reached, requiring payer authorization at execution time. Emits a payment_scheduled event on scheduling.
Contributor
|
please resolve your conflict |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #70
Closes #71
Closes #72
Closes #73
Allows the creator to call addrecipient() on a pending invoice as long as no payment has been received yet (funded == 0). Appends the new recipient and amount to the parallel recipients/amounts/tokens/claimed vecs, emits a recipient_added event, and writes an audit entry.