feat(contracts): add optional approver field and approve_invoice to i…#129
Merged
Conversation
…nvoice workflow (Stellar-split#25) - Added approver: Option<Address> and approved: bool fields to Invoice struct - Added approver field to InvoiceOptions for specifying an approver at invoice creation - Implemented approve_invoice() function requiring approver authentication - Updated release() to check approval gate when approver is set - Added comprehensive tests for approval workflow and non-approver invoices
|
@aji70 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional approval step to the invoice workflow. When an invoice is created with an approver address, approve_invoice() must be called by that approver before release() can execute.
Invoices without an approver are unaffected.
Changes
pass approver parameter
Testing
Closes #25