feat: add player match indexing and pagination support#708
Merged
famvilianity-eng merged 6 commits intoMay 30, 2026
Merged
Conversation
- Adds get_match_count() function to return total number of matches created - Updates DataKey enum to include PlayerMatches and OracleRecord variants - Increments match count on each create_match call
- Verifies match count starts at 0 - Asserts count increments after each create_match call - Tests multiple sequential creations
- Creates multiple matches for the same player - Verifies returned match IDs maintain insertion order - Ensures stable ordering for frontend pagination
- Creates separate matches for different player pairs - Verifies each player only sees their own match IDs - Ensures no data leakage between player indices
…pages - Creates 25 matches to test pagination boundaries - Verifies all match IDs are returned in order - Tests empty result set for players with no matches - Ensures pagination handles partial pages correctly
|
@benjaminjohnsonfin-afk Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements player match indexing and pagination support for the Checkmate-Escrow contract. Adds two new public getter functions (get_match_count() and get_player_matches()) and comprehensive test coverage for pagination boundaries, insertion order preservation, and player data isolation.
Related Issues
get_match_countincrements correctly #577: Add Test: get_match_count increments correctlyget_player_matchespreserves insertion order #578: Add Test: get_player_matches preserves insertion orderChanges
Tests Added
Closes #577
Closes #578
Closes #579
Closes #580