fix: reject empty game_id in create_match and add invariant tests#712
Merged
famvilianity-eng merged 2 commits intoMay 31, 2026
Conversation
Validate that game_id is non-empty before length check in create_match, returning Error::InvalidGameId on empty input. Wire up helpers and invariants test modules to the escrow test suite. Closes StellarCheckMate#657 Closes StellarCheckMate#605
|
@stellajose Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a missing validation guard in
create_matchthat rejects emptygame_idstrings before the length check, returningError::InvalidGameId. Also wires up thehelpersandinvariantstest modules into the escrow test suite.Changes
contracts/escrow/src/lib.rs— addedgame_id.is_empty()guard returningError::InvalidGameIdcontracts/escrow/src/tests/mod.rs— registeredhelpersandinvariantsmodulescontracts/escrow/src/tests/helpers.rs— new shared test helper utilitiescontracts/escrow/src/tests/invariants.rs— new invariant test coverageTesting
All changes include corresponding test coverage via the new invariants module.
Closes #657
Closes #605