PayPal Commerce by Crabcyborg · Pull Request #2678 · Strategy11/formidable-forms

Crabcyborg · 2025-12-22T14:33:21Z

Closes https://github.com/Strategy11/formidable-pro/issues/6124

Requires https://github.com/Strategy11/formidable-pro/pull/6381/changes to work properly with multi-page forms.

codecov · 2025-12-30T17:26:56Z

Codecov Report

❌ Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.69%. Comparing base (94f2ce4) to head (4dc9125).
⚠️ Report is 9 commits behind head on master.

Files with missing lines	Patch %	Lines
formidable.php	71.42%	4 Missing ⚠️
classes/controllers/FrmHooksController.php	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master    #2678   +/-   ##
=========================================
  Coverage     26.68%   26.69%           
  Complexity     8870     8870           
=========================================
  Files           145      145           
  Lines         29798    29785   -13     
=========================================
- Hits           7951     7950    -1     
+ Misses        21847    21835   -12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

coderabbitai · 2026-01-14T19:24:33Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6c773436-44d2-4aae-9cf2-d08220ccc75c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch paypal

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

deepsource-io · 2026-01-30T17:03:00Z

DeepSource Code Review

We reviewed changes in 1d27050...e5beaaf on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

Important

Some issues found as part of this review are outside of the diff in this pull request and aren't shown in the inline review comments due to GitHub's API limitations. You can see those issues on the DeepSource dashboard.

PR Report Card

Overall Grade	Security Reliability Complexity Hygiene

Code Review Summary

Analyzer	Status	Updated (UTC)	Details
PHP		May 7, 2026 12:21p.m.	Review ↗
JavaScript		May 7, 2026 12:21p.m.	Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

…t really creates a new payment action with paypal as the default gateway

…ent values in the SDK url based on the actions

… into paypal

…arning icons

deepsource-io · 2026-04-16T18:24:02Z

+		}
+
 		foreach ( $action_classes as $action_class ) {
 			self::$registered_actions->register( $action_class );


Cannot call method register() on array

The method you are trying to call is not defined, which can result in a fatal error.

deepsource-io · 2026-04-16T18:24:02Z

+		 * @param string $type
+		 * @param array  $field
+		 */
+		if ( apply_filters( 'frm_show_normal_field_type', $this->normal_field, $this->type, $this->field ) ) {


Function apply_filters invoked with 4 parameters, 2 required

The function call is not valid, which will result in a fatal runtime error.

deepsource-io · 2026-04-16T18:24:02Z

@@ -35,7 +35,7 @@
 		}

 		if ( $field['type'] === 'credit_card' && ! FrmAppHelper::pro_is_installed() ) {


Variable $field might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

deepsource-io · 2026-04-16T18:24:02Z

-			if ( ! FrmStrpLiteConnectHelper::at_least_one_mode_is_setup() && ! FrmSquareLiteConnectHelper::at_least_one_mode_is_setup() ) {
+			if ( ! FrmStrpLiteConnectHelper::at_least_one_mode_is_setup() && ! FrmSquareLiteConnectHelper::at_least_one_mode_is_setup() && ! FrmPayPalLiteConnectHelper::at_least_one_mode_is_setup() ) {
 				FrmStrpLiteAppHelper::not_connected_warning();
 			} elseif ( ! FrmTransLiteActionsController::get_actions_for_form( $field['form_id'] ) ) {


Variable $field might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

deepsource-io · 2026-04-16T18:24:02Z

 						<?php
 						/* translators: %1$s: Link HTML, %2$s: End link */
-						printf( esc_html__( 'Credit Cards will not work without %1$sadding a Collect Payment action%2$s.', 'formidable' ), '<a href="?page=formidable&frm_action=settings&id=' . absint( $field['form_id'] ) . '&t=email_settings" target="_blank">', '</a>' );
+						printf( esc_html__( 'Credit Cards will not work without %1$sadding a Stripe, Square, or PayPal action%2$s.', 'formidable' ), '<a href="?page=formidable&frm_action=settings&id=' . absint( $field['form_id'] ) . '&t=email_settings" target="_blank">', '</a>' );


Variable $field might not be defined

A variable has been used but not defined, which may result in warnings during program execution. This can also cause bugs since the intended usage scope of the variable is not known.

deepsource-io · 2026-04-16T18:24:03Z

+		$product                       = self::check_for_product( $status->products, 'PPCP_CUSTOM' );
+		$only_supports_checkout_button = false;
+
+		if ( ! $product || empty( $product->capabilities ) ) {


Access to an undefined property object|true::$capabilities

The property you are trying to access is not defined and will cause unexpected behavior when used.

deepsource-io · 2026-04-16T18:24:03Z

+				return false;
+			}
+
+			if ( 'ACTIVE' !== $product->status ) {


Cannot access property $status on object|true

The property you are trying to access is not defined and will cause unexpected behavior when used.

deepsource-io · 2026-04-16T18:24:03Z

+
+		echo '<li>' . esc_html__( 'PayPal Checkout', 'formidable' ) . '</li>';
+
+		$can_process_card_fields = ! $only_supports_checkout_button && in_array( 'CUSTOM_CARD_PROCESSING', $product->capabilities, true );


Cannot access property $capabilities on object|true

The property you are trying to access is not defined and will cause unexpected behavior when used.

deepsource-io · 2026-04-16T18:24:03Z

+	 * @return void
+	 */
+	private static function render_acdc_vetting_status( $product ) {
+		$vetting_status = $product && ! empty( $product->vetting_status ) ? $product->vetting_status : 'NOT_SET';


Access to an undefined property object|true::$vetting_status

The property you are trying to access is not defined and will cause unexpected behavior when used.

deepsource-io · 2026-04-16T18:24:03Z

+		/**
+		 * @var array $data->event_ids
+		 */
+		return $data->event_ids;


Cannot access property $event_ids on array

The property you are trying to access is not defined and will cause unexpected behavior when used.

deepsource-io · 2026-04-23T13:44:54Z

+	 *
+	 * @return array<int,mixed> Field ID => value pairs.
+	 */
+	private static function get_order_data_field_updates( $payer, $response, $settings ) {


`get_order_data_field_updates` has a cyclomatic complexity of 17 with "High" risk

A function with high cyclomatic complexity can be hard to understand and
maintain. Cyclomatic complexity is a software metric that measures the number of
independent paths through a function. A higher cyclomatic complexity indicates
that the function has more decision points and is more complex.

deepsource-io · 2026-04-23T13:44:54Z

+	 *
+	 * @return array<int,mixed> Field ID => new value pairs that differ from the current entry data.
+	 */
+	private static function get_payer_field_updates( $payer, $response, $action, $entry ) {


`get_payer_field_updates` has a cyclomatic complexity of 29 with "Very high" risk

A function with high cyclomatic complexity can be hard to understand and
maintain. Cyclomatic complexity is a software metric that measures the number of
independent paths through a function. A higher cyclomatic complexity indicates
that the function has more decision points and is more complex.

deepsource-io · 2026-04-23T13:44:54Z

+	 *
+	 * @return void
+	 */
+	public static function load_scripts( $form_id ) {


`load_scripts` has a cyclomatic complexity of 28 with "Very high" risk

A function with high cyclomatic complexity can be hard to understand and
maintain. Cyclomatic complexity is a software metric that measures the number of
independent paths through a function. A higher cyclomatic complexity indicates
that the function has more decision points and is more complex.

deepsource-io · 2026-04-23T13:44:54Z

+	 *
+	 * @return string
+	 */
+	private static function get_paypal_locale() { // phpcs:ignore Generic.Metrics.CyclomaticComplexity.MaxExceeded, SlevomatCodingStandard.Functions.FunctionLength.FunctionLength


`get_paypal_locale` has a cyclomatic complexity of 40 with "Very high" risk

A function with high cyclomatic complexity can be hard to understand and
maintain. Cyclomatic complexity is a software metric that measures the number of
independent paths through a function. A higher cyclomatic complexity indicates
that the function has more decision points and is more complex.

deepsource-io · 2026-04-29T18:59:25Z

+	 *
+	 * @return array
+	 */
+	public static function trigger_gateway( $action, $entry, $form ) {


`trigger_gateway` has a cyclomatic complexity of 20 with "High" risk

A function with high cyclomatic complexity can be hard to understand and
maintain. Cyclomatic complexity is a software metric that measures the number of
independent paths through a function. A higher cyclomatic complexity indicates
that the function has more decision points and is more complex.

…nflict with Stripe

coderabbitai · 2026-05-04T15:36:58Z

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details

{}

Crabcyborg marked this pull request as draft December 22, 2025 14:33

Crabcyborg changed the title ~~Paypal~~ PayPal Commerce Dec 22, 2025

Crabcyborg added run analysis run tests labels Dec 22, 2025

Crabcyborg removed run analysis run tests labels Dec 30, 2025

Crabcyborg added the run analysis label Jan 6, 2026

Crabcyborg added 20 commits January 30, 2026 17:30

Check that checkout is available if ppcp_custom is not

b61fff7

Merge branch 'master' into paypal

e7bcc42

Show the merchant ID as well

95f1a88

Merge branch 'master' into paypal

c87ed11

Fix typo, spacing isuse

597c5bc

Merge branch 'master' into paypal

f1d1fcc

Modify the default paypal action so it does not appear disabled and i…

3e6aba7

…t really creates a new payment action with paypal as the default gateway

Fix indentation

b0ac5ec

Add action icons for Square and Stripe too

584fbdb

Make the icons look nicer

7297ef7

Merge branch 'master' into paypal

0d0be74

Merge branch 'master' into paypal

5a3f6b2

Merge branch 'master' into paypal

53b3d36

Add comment

4e4fd04

Merge branch 'master' into paypal

b5216cc

Test data

f09c65e

Merge branch 'master' into paypal

7519c16

Merge branch 'master' into paypal

9dc10fe

Pull the client id from global vars and populate the currency and int…

5f29189

…ent values in the SDK url based on the actions

Remove irrelevant client ids

4c6474e

Crabcyborg added 6 commits April 6, 2026 17:14

Merge branch 'paypal' of https://github.com/Strategy11/formidable-forms…

95a3f98

… into paypal

Update settings hooks to be consistent with Stripe add-on

82d59f7

Add required asterisk and warning when product name is empty

cd25c32

Add recurring type check as well before showing warning

de450a4

Show warnings if amount is not set and add a required asterisk, add w…

f235ea4

…arning icons

Merge branch 'master' into paypal

ef08eb5

deepsource-io Bot reviewed Apr 16, 2026

View reviewed changes

Crabcyborg added 6 commits April 22, 2026 13:43

Merge branch 'master' into paypal

4ba6fae

Fix incorrect type

8dcd9e8

Fix bug with methchant ID appearing as N/A in error messages

abfad6a

Only show the JS error message instead of the whole JSON

2421583

Show the error message when creating/capturing order fails

9e6863d

Translate the fallback

69d2ccf

deepsource-io Bot reviewed Apr 23, 2026

View reviewed changes

Crabcyborg added 7 commits April 23, 2026 11:20

Remove unnecessary checks for $headers since it is never empty

98798fd

Show option to reconnect when oauth integrations is empty

e31579f

Remove unused API endpoint

9ee41fc

Add meta more consistently

d176d03

Include shipping info in paypal order data

432f350

Always use the production BN code

722b644

Add logic for pending payments

a949396

deepsource-io Bot reviewed Apr 29, 2026

View reviewed changes

Crabcyborg added 5 commits April 30, 2026 13:33

Log PayPal debug IDs

c531a97

Fix possible issue with apple pay using $0 amount

3db1ea2

Add check for connection before making request to create order

6452b07

Working on improving error handling

47ce24e

Working on displaying debug IDs for errors, prevent layout setting co…

5c3d8a1

…nflict with Stripe

Error handling tweaks

e5beaaf

Crabcyborg mentioned this pull request May 8, 2026

Form actions refresh plus paypal #3093

Open

		@@ -35,7 +35,7 @@
		}

		if ( $field['type'] === 'credit_card' && ! FrmAppHelper::pro_is_installed() ) {


		echo '<li>' . esc_html__( 'PayPal Checkout', 'formidable' ) . '</li>';

		$can_process_card_fields = ! $only_supports_checkout_button && in_array( 'CUSTOM_CARD_PROCESSING', $product->capabilities, true );

Conversation

Crabcyborg commented Dec 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Dec 30, 2025

Codecov Report

Uh oh!

coderabbitai Bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

deepsource-io Bot commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

DeepSource Code Review

PR Report Card

Code Review Summary

Uh oh!

deepsource-io Bot Apr 16, 2026

Choose a reason for hiding this comment

Cannot call method register() on array

Uh oh!

deepsource-io Bot Apr 16, 2026

Choose a reason for hiding this comment

Function apply_filters invoked with 4 parameters, 2 required

Uh oh!

deepsource-io Bot Apr 16, 2026

Choose a reason for hiding this comment

Variable $field might not be defined

Uh oh!

deepsource-io Bot Apr 16, 2026

Choose a reason for hiding this comment

Variable $field might not be defined

Uh oh!

deepsource-io Bot Apr 16, 2026

Choose a reason for hiding this comment

Variable $field might not be defined

Uh oh!

deepsource-io Bot Apr 16, 2026

Choose a reason for hiding this comment

Access to an undefined property object|true::$capabilities

Uh oh!

deepsource-io Bot Apr 16, 2026

Choose a reason for hiding this comment

Cannot access property $status on object|true

Uh oh!

deepsource-io Bot Apr 16, 2026

Choose a reason for hiding this comment

Cannot access property $capabilities on object|true

Uh oh!

deepsource-io Bot Apr 16, 2026

Choose a reason for hiding this comment

Access to an undefined property object|true::$vetting_status

Uh oh!

deepsource-io Bot Apr 16, 2026

Choose a reason for hiding this comment

Cannot access property $event_ids on array

Uh oh!

deepsource-io Bot Apr 23, 2026

Choose a reason for hiding this comment

`get_order_data_field_updates` has a cyclomatic complexity of 17 with "High" risk

Uh oh!

deepsource-io Bot Apr 23, 2026

Choose a reason for hiding this comment

`get_payer_field_updates` has a cyclomatic complexity of 29 with "Very high" risk

Uh oh!

deepsource-io Bot Apr 23, 2026

Choose a reason for hiding this comment

`load_scripts` has a cyclomatic complexity of 28 with "Very high" risk

Uh oh!

deepsource-io Bot Apr 23, 2026

Choose a reason for hiding this comment

`get_paypal_locale` has a cyclomatic complexity of 40 with "Very high" risk

Uh oh!

deepsource-io Bot Apr 29, 2026

Choose a reason for hiding this comment

`trigger_gateway` has a cyclomatic complexity of 20 with "High" risk

Uh oh!

coderabbitai Bot commented May 4, 2026

Uh oh!

Reviewers

Crabcyborg commented Dec 22, 2025 •

edited

Loading

coderabbitai Bot commented Jan 14, 2026 •

edited

Loading

deepsource-io Bot commented Jan 30, 2026 •

edited

Loading