Rock: Form Actions Refresh#2999
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughRedesigned the form-actions picker into a tabbed/filter UI with Pro gating, centralized action descriptions, icon/markup refactors, new JS modules (filter + visibility observer), many CSS/SCSS utility additions and adjustments, and build/watch config updates. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
 |
|
Overall Grade |
Security  Reliability  Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| PHP |  |
May 7, 2026 12:57p.m. | Review ↗ |
| JavaScript |  |
May 7, 2026 12:57p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
…nd remove border from settings h2
…itle, description, and add button
…, add grid layout class to action lists, and move search box class to frm-ml-auto-force
Add data-filter attributes to tab navigation for filtering actions. Include data-filter-target for targeting filter content area. Add group key iteration for proper filter mapping.
Wrap action groups in data-group divs for filter targeting. Remove show/hide buttons and clear divs. Simplify layout structure for better filtering functionality.
Check for data-filter-target before switching action classes. Skip frm-all-actions/frm-limited-actions toggle when filter tabs are present.
Add filterTarget detection and applyFilter method for content filtering. Handle data-filter attributes on nav items to show/hide content groups. Set activeFilter dataset for CSS-driven visibility changes.
…ontrols and group heading display
… markup to match template structure
…ring in default-value-field.php and textarea-default-value-field.php
…prove ignored error patterns
… in field-options.php
…t into backwards compatibility index
|
I am seeing one last little visual issue when you unselect the advanced scoring option in the quiz action. 2026-04-21.16-27-45.mp4 |
garretlaxton
left a comment
garretlaxton
left a comment
There was a problem hiding this comment.
Thanks @shervElmi, this looks good to me! I haven't been able to find anything else.
…epsource-phpdocs Fix DeepSource Warnings
…lder compatibility
…rock/form-actions-a11y-keyboard-nav
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2999 +/- ##
============================================
- Coverage 26.51% 26.42% -0.10%
- Complexity 9105 9138 +33
============================================
Files 149 149
Lines 30607 30752 +145
============================================
+ Hits 8115 8125 +10
- Misses 22492 22627 +135 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…compat Form actions refresh paypal compat
…ard-nav Rock/form actions a11y keyboard nav
… improved user experience.
…lback based on action ID, ensuring consistent rendering across requests.
3 participants
Figma Design
https://www.figma.com/design/QnMV8Njb7k5hDSdgrvNveY/Form-Actions-Refresh?node-id=2522-4144&t=WoMZkL9AfPzAzRph-1
Add-Ons PRs