Skip to content

Show skipped rows count after CSV import #3059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AbdiTolesa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Show skipped rows count after CSV import #3059

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions classes/controllers/FrmEntriesController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,10 @@ public static function display_list( $message = '', $errors = array() ) {

if ( ! $message && isset( $_GET['import-message'] ) ) {
$message = __( 'Your import is complete', 'formidable' );
$skipped = isset( $_GET['skipped'] ) ? intval( $_GET['skipped'] ) : 0;
if ( $skipped > 0 ) {
$message .= ' ' . sprintf( __( '(%d rows skipped)', 'formidable' ), $skipped );
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Use plural-aware translation for skipped row count.

__( '(%d rows skipped)', 'formidable' ) produces incorrect grammar for 1 and is harder to localize. Please switch to _n() with the count.

💡 Suggested fix 
-				$message .= ' ' . sprintf( __( '(%d rows skipped)', 'formidable' ), $skipped );
+				$message .= ' ' . sprintf(
+					_n( '(%d row skipped)', '(%d rows skipped)', $skipped, 'formidable' ),
+					$skipped
+				);
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
$message .= ' ' . sprintf( __( '(%d rows skipped)', 'formidable' ), $skipped );
$message .= ' ' . sprintf(
_n( '(%d row skipped)', '(%d rows skipped)', $skipped, 'formidable' ),
$skipped
);
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@classes/controllers/FrmEntriesController.php` at line 648, Replace the
plural-incorrect call to __( '(%d rows skipped)', 'formidable' ) with a
plural-aware _n() usage: use _n( '(%d row skipped)', '(%d rows skipped)',
$skipped, 'formidable' ) and pass $skipped into sprintf so $message .= ' ' .
sprintf( _n(...), $skipped ); update the concatenation where $message and
$skipped are used (in FrmEntriesController around the code that appends skipped
row info) to ensure correct singular/plural translations.

}
}

require FrmAppHelper::plugin_path() . '/classes/views/frm-entries/list.php';
Expand Down
627 changes: 626 additions & 1 deletion css/admin/frm-settings-components.css
View file
Open in desktop

Large diffs are not rendered by default.

153 changes: 152 additions & 1 deletion css/admin/welcome-tour.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

89 changes: 88 additions & 1 deletion css/font_icons.css
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11,960 changes: 11,958 additions & 2 deletions css/frm_admin.css
View file
Open in desktop

Large diffs are not rendered by default.

2,870 changes: 2,868 additions & 2 deletions css/frm_testing_mode.css
View file
Open in desktop

Large diffs are not rendered by default.

4,846 changes: 4,845 additions & 1 deletion js/addons-page.js
View file
Open in desktop

Large diffs are not rendered by default.

6,800 changes: 6,798 additions & 2 deletions js/form-templates.js
View file
Open in desktop

Large diffs are not rendered by default.

2,927 changes: 2,926 additions & 1 deletion js/formidable-settings-components.js
View file
Open in desktop

Large diffs are not rendered by default.

5,831 changes: 5,830 additions & 1 deletion js/formidable-web-components.js
View file
Open in desktop

Large diffs are not rendered by default.

13,398 changes: 13,397 additions & 1 deletion js/formidable_admin.js
View file
Open in desktop

Large diffs are not rendered by default.

2,716 changes: 2,715 additions & 1 deletion js/formidable_blocks.js
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading