fix: create liblualib.a symlink for Lua 5.1+ installs#50
Closed
tyrro wants to merge 1 commit intoStratus3D:masterfrom
Closed
fix: create liblualib.a symlink for Lua 5.1+ installs#50tyrro wants to merge 1 commit intoStratus3D:masterfrom
tyrro wants to merge 1 commit intoStratus3D:masterfrom
Conversation
liblualib was merged into liblua in Lua 5.1. Static libraries built from Lua 5.1+ source only ship liblua.a, but gems like ruby-lua still link against -llualib, causing the build to fail with 'library not found'. Create a liblualib.a -> liblua.a symlink after install when: - The version is Lua 5.1 or greater (not LuaJIT) - liblua.a exists in the install's lib directory - liblualib.a is not already present (future-safe)
Closed
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
@Stratus3D the CI is failing
any suggestion to fix it? |
Owner
|
I'm closing this PR. See #39 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since Lua 5.1,
liblualibwas merged intoliblua. Lua 5.1+ installs built from source only produceliblua.a, but older native extensions (e.g. theruby-luagem) still link against-llualib. This causes the build to fail:Solution
After copying the Lua files to the install path, create a
liblualib.a → liblua.asymlink when:liblua.ais present in the install'slib/directoryliblualib.adoes not already exist (no-op if a future release ships it again)This matches what package managers like Homebrew do when installing Lua.