Skip to content

Add visually hidden document labels to buttons for accessibility #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nonprofittechy wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add visually hidden document labels to buttons for accessibility #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3220922
Fix #1054 - add visually hidden document labels to buttons so style r…
nonprofittechy May 20, 2026
94a5e35
Correct default for standalone use of send_button_html()
nonprofittechy May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions docassemble/AssemblyLine/al_document.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2224,7 +2224,7 @@ def download_list_html(
download_doc.url_for(
attachment=True, display_filename=download_filename
),
label=download_label,
label=f'{download_label} <span class="visually-hidden">{title}</span>',
icon=download_icon,
color="primary",
size="md",
Expand All @@ -2239,7 +2239,7 @@ def download_list_html(
result["pdf"].url_for(
attachment=False, display_filename=view_filename
),
label=view_label,
label=f'{view_label} <span class="visually-hidden">{title}</span>',
icon=view_icon,
color="secondary",
size="md",
Expand Down Expand Up @@ -2503,7 +2503,7 @@ def send_button_html(
key: str = "final",
show_editable_checkbox: bool = True,
template_name: str = "",
label: str = "Send",
label: Optional[str] = None,
icon: str = "envelope",
preferred_formats: Optional[Union[str, List[str]]] = None,
email_legend_class: str = "h4",
Expand Down Expand Up @@ -2532,6 +2532,9 @@ def send_button_html(
Returns:
str: The generated HTML string for the input box and button.
"""
if label is None:
label = str(self.send_label) or word("Send")

if not self.has_enabled_documents():
return "" # Don't let people email an empty set of documents

Expand Down
4 changes: 2 additions & 2 deletions docassemble/AssemblyLine/data/questions/al_document.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,12 @@ content: |
generic object: ALDocumentBundle
template: x.zip_label
content: |
Download all
Download all <span class="visually-hidden">${ x.title }</span> documents
---
generic object: ALDocumentBundle
template: x.full_pdf_label
content: |
Download as one PDF
Download <span class="visually-hidden">${ x.title }</span> as one PDF
---
id: al exhibit ocr pages bg
event: al_exhibit_ocr_pages
Expand Down
6 changes: 4 additions & 2 deletions docassemble/AssemblyLine/data/questions/ql_baseline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2668,8 +2668,10 @@ content: "Download"
---
generic object: ALDocumentBundle
template: x.send_label
content: "Send"
content: |
Send <span class="visually-hidden">${ x.title } documents</span>
---
generic object: ALDocumentBundle
template: x.send_button_to_label
content: "Send"
content: |
Send <span class="visually-hidden">${ x.title } documents</span>
Loading