Server: session-manager.ts cleanup + grant request tracking#185
Closed
SuuBro wants to merge 1 commit intogoal/simplify-t-703f66e2from
Closed
Server: session-manager.ts cleanup + grant request tracking#185SuuBro wants to merge 1 commit intogoal/simplify-t-703f66e2from
SuuBro wants to merge 1 commit intogoal/simplify-t-703f66e2from
Conversation
- Remove permissionBroadcastSent flag from SessionInfo - Remove error regex matching block (~70 lines) that detected tool denials from tool_execution_end/message_end events - Remove policy-to-mode override logic in grantToolPermission (always-ask→ one-time, ask-once→session-only) — user's chosen mode now respected directly - Remove never-ask/never filtering of newTools in grantToolPermission - Add pendingGrantRequest tracking to SessionInfo for guard extension long-poll - Add requestToolGrant() method: creates pending request, broadcasts tool_permission_needed to UI clients, returns promise resolved by grantToolPermission or after 5-minute timeout - Resolve pending grant request at end of grantToolPermission flow Co-authored-by: bobbit-ai <bobbit@bobbit.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove old tool denial detection mechanisms and add grant request tracking for the new tool_call guard architecture.
Removed:
permissionBroadcastSentflag from SessionInfoAdded:
pendingGrantRequestfield on SessionInfo for guard extension long-poll trackingrequestToolGrant()method: creates pending request, broadcasts tool_permission_needed to UI, returns promise resolved by grantToolPermission or after 5-minute timeout🤖 Generated with Bobbit