Skip to content

v1.1.2 add instagram and facebook link to weblinks widget#120

Merged
konrad2002 merged 1 commit intomasterfrom
develop
Sep 23, 2025
Merged

v1.1.2 add instagram and facebook link to weblinks widget#120
konrad2002 merged 1 commit intomasterfrom
develop

Conversation

@konrad2002
Copy link
Member

@konrad2002 konrad2002 commented Sep 23, 2025

Summary by CodeRabbit

  • New Features
    • Added Instagram and Facebook link tiles to the small Weblinks widget. Links appear only when corresponding URLs are available.
  • Translations
    • Added Instagram and Facebook link text translations in English and German.
    • Introduced full Weblinks translation block in Ukrainian, including title and link texts for Livestream, Website, Instagram, and Facebook.

@konrad2002 konrad2002 added this to the v1.1.1 milestone Sep 23, 2025
@konrad2002 konrad2002 self-assigned this Sep 23, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 23, 2025

Walkthrough

Adds Instagram and Facebook link tiles to the weblinks-small component template, conditionally rendered based on meeting.data URLs. Updates i18n files (de, en, ua) to include corresponding WEBLINKS translation keys, including titles and link texts. No changes to exported/public code entities or component logic beyond template conditional rendering.

Changes

Cohort / File(s) Summary of Changes
Widget template update
src/app/shared/widget/widgets/weblinks/widget-weblinks-small/widget-weblinks-small.component.html
Added conditional tiles for Instagram and Facebook with icons, translated labels, and hrefs bound to meeting.data.instagram_url and meeting.data.facebook_url.
i18n: German & English additions
src/assets/i18n/de.json, src/assets/i18n/en.json
Introduced WIDGET.WEBLINKS.INSTAGRAM_LINK_TEXT and ...FACEBOOK_LINK_TEXT; maintained existing structure, adjusted commas as needed.
i18n: Ukrainian WEBLINKS block
src/assets/i18n/ua.json
Added WIDGET.FILE.WEBLINKS object with TITLE, LIVESTREAM_LINK_TEXT, WEBSITE_LINK_TEXT, INSTAGRAM_LINK_TEXT, FACEBOOK_LINK_TEXT.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant Component as WeblinksSmallComponent
  participant Data as meeting.data
  participant I18N as TranslationService

  User->>Component: Load widget
  Component->>Data: Check instagram_url / facebook_url
  alt URL present
    Component->>I18N: t('WIDGET.WEBLINKS.INSTAGRAM_LINK_TEXT' / '...FACEBOOK_LINK_TEXT')
    I18N-->>Component: Localized text
    Component-->>User: Render link tiles with hrefs
  else URL missing
    Component-->>User: Do not render those tiles
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I hopped through links, two paws at the ready,
Added Insta and Face, neat and steady.
Translations aligned, tidy and bright,
Tiny tiles bloom in the widget’s light.
With a twitch of whiskers and JSON delight,
I ship these hops into the night. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title accurately summarizes the primary change—adding Instagram and Facebook links to the weblinks widget—and matches the template and i18n updates in the diff, making it concise and specific. The leading "v1.1.1" is extra metadata but does not obscure the PR's intent.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a134f21 and c9f71d6.

📒 Files selected for processing (4)
  • src/app/shared/widget/widgets/weblinks/widget-weblinks-small/widget-weblinks-small.component.html (1 hunks)
  • src/assets/i18n/de.json (1 hunks)
  • src/assets/i18n/en.json (1 hunks)
  • src/assets/i18n/ua.json (2 hunks)
🔇 Additional comments (4)
src/assets/i18n/de.json (1)

346-348: DE translations OK. Mirror keys in remaining locales.

Matches EN structure/keys. Verify CZ and RU (if present) to prevent missing translations.

Use the same script provided in EN comment to spot gaps.

src/assets/i18n/ua.json (1)

269-276: UA translations OK and correctly placed under WIDGET.WEBLINKS.

Structure and keys align with EN/DE.

src/app/shared/widget/widgets/weblinks/widget-weblinks-small/widget-weblinks-small.component.html (1)

18-31: Approve — model fields present.
meeting.data exposes instagram_url and facebook_url (src/app/core/model/meeting/meeting-data.model.ts); template is fine.
Optional: add target="_blank" rel="noopener noreferrer" on external links for safety/UX.

src/assets/i18n/en.json (1)

342-345: Translations added — looks good; verify other locales are in sync.
Sandbox verification failed; run this locally to list any missing WIDGET.WEBLINKS keys:

python3 - <<'PY'
import json,glob,sys,os
en='src/assets/i18n/en.json'
if not os.path.isfile(en):
    print('EN file not found:',en); sys.exit(1)
with open(en,encoding='utf-8') as f: e=json.load(f)
expected=set(e.get('WIDGET',{}).get('WEBLINKS',{}).keys())
if not expected:
    print('No WIDGET.WEBLINKS keys found in',en); sys.exit(1)
for p in sorted(glob.glob('src/assets/i18n/*.json')):
    with open(p,encoding='utf-8') as f: j=json.load(f)
    keys=set(j.get('WIDGET',{}).get('WEBLINKS',{}).keys())
    missing=sorted(expected-keys)
    if missing:
        print('==',p,'==')
        for k in missing: print('MISSING:',k)
PY

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@konrad2002 konrad2002 changed the title v1.1.1 add instagram and facebook link to weblinks widget v1.1.2 add instagram and facebook link to weblinks widget Sep 23, 2025
@konrad2002 konrad2002 modified the milestones: v1.1.1, v1.1.2 Sep 23, 2025
@konrad2002 konrad2002 merged commit 3958b0a into master Sep 23, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant