Skip to content

Patch: event list scroll to top; livetiming controls on top#125

Merged
konrad2002 merged 2 commits intomasterfrom
develop
Dec 21, 2025
Merged

Patch: event list scroll to top; livetiming controls on top#125
konrad2002 merged 2 commits intomasterfrom
develop

Conversation

@konrad2002
Copy link
Member

@konrad2002 konrad2002 commented Dec 21, 2025

Summary by CodeRabbit

  • Improvements

    • Page now automatically scrolls to the top after loading event data, improving navigation experience when viewing event details and results.
  • User Interface

    • Reorganized live timing controls placement for improved layout and accessibility.

✏️ Tip: You can customize this high-level summary in your review settings.

@konrad2002 konrad2002 self-assigned this Dec 21, 2025
@konrad2002 konrad2002 merged commit 01abc6e into master Dec 21, 2025
4 of 5 checks passed
@coderabbitai
Copy link

coderabbitai bot commented Dec 21, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Two UX improvements are implemented. One adds automatic page scrolling to the top after data fetches in an event view component. The other repositions navigation controls in a live timing template, moving them earlier in the component structure for improved layout.

Changes

Cohort / File(s) Summary
Auto-scroll behavior
src/app/content/events/components/event-view/event-view.component.ts
Adds window.scrollTo(0, 0) calls after data fetch completion in fetchStarts and fetchResultStarts methods to automatically scroll page to top.
Live timing controls repositioning
src/app/content/live/components/livetiming/livetiming.component.html
Relocates sr-livetiming-controls element to appear immediately after sr-livetiming-header, with all bindings and event handlers ((changeHeat), currentEvent, currentHeat, heatAmount, hasPrevEvent, hasNextEvent) preserved. Removes original placement from later in template.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

  • Both changes are straightforward additions/repositioning with minimal logic impact
  • First file adds two simple function calls to existing methods
  • Second file relocates an existing template element without functional modifications

Poem

🐰 A hop and a scroll, controls in their place,
The page springs to life at a measured pace,
Layout refined, no corners cut short,
Small tweaks that make navigation more sport!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b0c8ff8 and 025de4c.

📒 Files selected for processing (2)
  • src/app/content/events/components/event-view/event-view.component.ts (2 hunks)
  • src/app/content/live/components/livetiming/livetiming.component.html (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant