refactor(event): streamline event controller error handling and improve code clarity#1504
Open
tyler-dane wants to merge 5 commits intomainfrom
Open
refactor(event): streamline event controller error handling and improve code clarity#1504tyler-dane wants to merge 5 commits intomainfrom
tyler-dane wants to merge 5 commits intomainfrom
Conversation
…ve code clarity - Removed try/catch blocks in the create, delete, and update methods of the EventController, replacing them with promise-based error handling using `res.promise()`. - Added comprehensive JSDoc comments to the EventController class, detailing the purpose and functionality of the methods, particularly regarding error routing through the centralized error handler. - This refactor enhances code readability and maintains consistent error management across event operations.
…packages - Added new dependencies for @InQuirer packages in yarn.lock, including @inquirer/ansi, @inquirer/checkbox, @inquirer/confirm, and others, to enhance user interaction capabilities. - Updated package.json to include @inquirer/prompts version 8.3.0, ensuring the latest features and improvements are available for user prompts. - This update improves the project's dependency management and ensures compatibility with the latest inquirer functionalities.
tyler-dane
force-pushed
the
fix/1483-400-cleanup
branch
from
e8c441c to
abf2c22
Compare
…idation - Introduced the `isGoogleError` utility to identify GaxiosError-like objects, improving error detection for Google API responses. - Updated `isInvalidGoogleToken` to handle both string and numeric error codes, ensuring robust validation of invalid tokens. - Added comprehensive tests for various Google error scenarios, including handling of GaxiosError-like structures and numeric error codes. - This enhancement improves error management and user feedback during Google Calendar synchronization processes.
…ogle revocation handling - Updated imports to streamline the authentication state utilities, moving from common utils to dedicated auth state utilities. - Implemented new in-memory state management for Google authentication revocation, allowing for better handling of user sessions without persisting unnecessary data. - Added comprehensive tests for the new Google authentication state utilities, ensuring robust functionality for revocation and session management. - Enhanced existing components and hooks to utilize the new state management, improving overall code clarity and maintainability.
…gle handling - Refactored imports to transition from common utility paths to dedicated authentication state utilities for better organization. - Introduced a new `clearAuthenticationState` function to manage user logout processes effectively. - Enhanced tests to cover the new Google authentication state utilities and ensure robust functionality. - Updated various components and hooks to utilize the revised authentication state management, improving code clarity and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
res.promise().Closes #1483