Resolved byte object vs string conflict#2
Open
sihatafnan wants to merge 2 commits intoSyNSec-den:mainfrom
Open
Resolved byte object vs string conflict#2sihatafnan wants to merge 2 commits intoSyNSec-den:mainfrom
sihatafnan wants to merge 2 commits intoSyNSec-den:mainfrom
Conversation
converted cmd to string from byte object so that it can be used in equality checking converted response to byte object from string which is necessary to send it over socket
Update device.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converted cmd from byte object to its string representation so that it can be used in equality checking.
Also, converted the response from string to byte object before sending over socket medium.